From 0b898b9aab5c2349beb5ae9a8ce03fd4e172d1ab Mon Sep 17 00:00:00 2001 From: Sergio Afonso Date: Thu, 28 Sep 2023 13:47:06 +0100 Subject: [PATCH] [Flang][Lower] Add lowering support of OpenMP distribute to MLIR This patch adds support for lowering the OpenMP distribute directive from PFT to MLIR. This in turn unlocks support for several related combined loop constructs as well. --- flang/lib/Lower/OpenMP.cpp | 41 +- flang/test/Lower/OpenMP/FIR/if-clause.f90 | 902 +++++++++++++++++- flang/test/Lower/OpenMP/FIR/loop-combined.f90 | 162 +++- flang/test/Lower/OpenMP/distribute.f90 | 117 +++ 4 files changed, 1169 insertions(+), 53 deletions(-) create mode 100644 flang/test/Lower/OpenMP/distribute.f90 diff --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp index 5f5e968eaaa641..37ad86d6ac599a 100644 --- a/flang/lib/Lower/OpenMP.cpp +++ b/flang/lib/Lower/OpenMP.cpp @@ -497,6 +497,9 @@ class ClauseProcessor { bool processDevice(Fortran::lower::StatementContext &stmtCtx, mlir::Value &result) const; bool processDeviceType(mlir::omp::DeclareTargetDeviceType &result) const; + bool processDistSchedule(Fortran::lower::StatementContext &stmtCtx, + mlir::UnitAttr &scheduleStatic, + mlir::Value &chunkSize) const; bool processFinal(Fortran::lower::StatementContext &stmtCtx, mlir::Value &result) const; bool processHint(mlir::IntegerAttr &result) const; @@ -1335,6 +1338,19 @@ bool ClauseProcessor::processDeviceType( return false; } +bool ClauseProcessor::processDistSchedule( + Fortran::lower::StatementContext &stmtCtx, mlir::UnitAttr &scheduleStatic, + mlir::Value &chunkSize) const { + if (auto *distScheduleClause = findUniqueClause()) { + scheduleStatic = converter.getFirOpBuilder().getUnitAttr(); + if (const auto *expr = Fortran::semantics::GetExpr(distScheduleClause->v)) { + chunkSize = fir::getBase(converter.genExprValue(*expr, stmtCtx)); + } + return true; + } + return false; +} + bool ClauseProcessor::processFinal(Fortran::lower::StatementContext &stmtCtx, mlir::Value &result) const { const Fortran::parser::CharBlock *source = nullptr; @@ -2473,6 +2489,27 @@ genTeamsOp(Fortran::lower::AbstractConverter &converter, reductionDeclSymbols)); } +static mlir::omp::DistributeOp +genDistributeOp(Fortran::lower::AbstractConverter &converter, + Fortran::lower::pft::Evaluation &eval, + mlir::Location currentLocation, + const Fortran::parser::OmpClauseList &clauseList, + bool outerCombined = false) { + Fortran::lower::StatementContext stmtCtx; + mlir::UnitAttr scheduleStatic; + mlir::Value chunkSize; + llvm::SmallVector allocateOperands, allocatorOperands; + + ClauseProcessor cp(converter, clauseList); + cp.processDistSchedule(stmtCtx, scheduleStatic, chunkSize); + cp.processAllocate(allocatorOperands, allocateOperands); + + return genOpWithBody( + converter, eval, currentLocation, outerCombined, &clauseList, + scheduleStatic, chunkSize, allocateOperands, allocatorOperands, + /*order_val=*/nullptr); +} + /// Extract the list of function and variable symbols affected by the given /// 'declare target' directive and return the intended device type for them. static mlir::omp::DeclareTargetDeviceType getDeclareTargetInfo( @@ -2681,7 +2718,9 @@ static void genOMP(Fortran::lower::AbstractConverter &converter, } if (llvm::omp::allDistributeSet.test(ompDirective)) { validDirective = true; - TODO(currentLocation, "Distribute construct"); + bool outerCombined = llvm::omp::topDistributeSet.test(ompDirective); + genDistributeOp(converter, eval, currentLocation, loopOpClauseList, + outerCombined); } if ((llvm::omp::allParallelSet & llvm::omp::loopConstructSet) .test(ompDirective)) { diff --git a/flang/test/Lower/OpenMP/FIR/if-clause.f90 b/flang/test/Lower/OpenMP/FIR/if-clause.f90 index ef98a00f10dbd2..bf77c3edaefed1 100644 --- a/flang/test/Lower/OpenMP/FIR/if-clause.f90 +++ b/flang/test/Lower/OpenMP/FIR/if-clause.f90 @@ -7,23 +7,147 @@ program main integer :: i ! TODO When they are supported, add tests for: - ! - DISTRIBUTE PARALLEL DO - ! - DISTRIBUTE PARALLEL DO SIMD - ! - DISTRIBUTE SIMD ! - PARALLEL SECTIONS ! - PARALLEL WORKSHARE - ! - TARGET PARALLEL - ! - TARGET TEAMS DISTRIBUTE - ! - TARGET TEAMS DISTRIBUTE PARALLEL DO - ! - TARGET TEAMS DISTRIBUTE PARALLEL DO SIMD - ! - TARGET TEAMS DISTRIBUTE SIMD ! - TARGET UPDATE ! - TASKLOOP ! - TASKLOOP SIMD - ! - TEAMS DISTRIBUTE - ! - TEAMS DISTRIBUTE PARALLEL DO - ! - TEAMS DISTRIBUTE PARALLEL DO SIMD - ! - TEAMS DISTRIBUTE SIMD + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp distribute parallel do simd + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp distribute parallel do simd if(.true.) + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp distribute parallel do simd if(parallel: .true.) if(simd: .false.) + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp distribute parallel do simd if(parallel: .true.) + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp distribute parallel do simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + !$omp end teams + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE PARALLEL DO + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp distribute parallel do + do i = 1, 10 + end do + !$omp end distribute parallel do + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp distribute parallel do if(.true.) + do i = 1, 10 + end do + !$omp end distribute parallel do + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp distribute parallel do if(parallel: .true.) + do i = 1, 10 + end do + !$omp end distribute parallel do + + !$omp end teams + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp distribute simd + do i = 1, 10 + end do + !$omp end distribute simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp distribute simd if(.true.) + do i = 1, 10 + end do + !$omp end distribute simd + + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp distribute simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end distribute simd + + !$omp end teams ! ---------------------------------------------------------------------------- ! DO SIMD @@ -362,6 +486,53 @@ program main end do !$omp end target parallel do simd + ! ---------------------------------------------------------------------------- + ! TARGET PARALLEL + ! ---------------------------------------------------------------------------- + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target parallel + i = 1 + !$omp end target parallel + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target parallel if(.true.) + i = 1 + !$omp end target parallel + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target parallel if(target: .true.) if(parallel: .false.) + i = 1 + !$omp end target parallel + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target parallel if(target: .true.) + i = 1 + !$omp end target parallel + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target parallel if(parallel: .true.) + i = 1 + !$omp end target parallel + ! ---------------------------------------------------------------------------- ! TARGET SIMD ! ---------------------------------------------------------------------------- @@ -415,71 +586,724 @@ program main !$omp end target simd ! ---------------------------------------------------------------------------- - ! TARGET TEAMS + ! TARGET TEAMS DISTRIBUTE ! ---------------------------------------------------------------------------- - ! CHECK: omp.target ! CHECK-NOT: if({{.*}}) ! CHECK-SAME: { ! CHECK: omp.teams ! CHECK-NOT: if({{.*}}) ! CHECK-SAME: { - !$omp target teams - i = 1 - !$omp end target teams + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute + do i = 1, 10 + end do + !$omp end target teams distribute ! CHECK: omp.target ! CHECK-SAME: if({{.*}}) ! CHECK: omp.teams ! CHECK-SAME: if({{.*}}) - !$omp target teams if(.true.) - i = 1 - !$omp end target teams + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute if(.true.) + do i = 1, 10 + end do + !$omp end target teams distribute ! CHECK: omp.target ! CHECK-SAME: if({{.*}}) ! CHECK: omp.teams ! CHECK-SAME: if({{.*}}) - !$omp target teams if(target: .true.) if(teams: .false.) - i = 1 - !$omp end target teams + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute if(target: .true.) if(teams: .false.) + do i = 1, 10 + end do + !$omp end target teams distribute ! CHECK: omp.target ! CHECK-SAME: if({{.*}}) ! CHECK: omp.teams ! CHECK-NOT: if({{.*}}) ! CHECK-SAME: { - !$omp target teams if(target: .true.) - i = 1 - !$omp end target teams + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute if(target: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute ! CHECK: omp.target ! CHECK-NOT: if({{.*}}) ! CHECK-SAME: { ! CHECK: omp.teams ! CHECK-SAME: if({{.*}}) - !$omp target teams if(teams: .true.) - i = 1 - !$omp end target teams + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute if(teams: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute ! ---------------------------------------------------------------------------- - ! TASK + ! TARGET TEAMS DISTRIBUTE PARALLEL DO ! ---------------------------------------------------------------------------- - ! CHECK: omp.task + ! CHECK: omp.target ! CHECK-NOT: if({{.*}}) ! CHECK-SAME: { - !$omp task - !$omp end task + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do + do i = 1, 10 + end do + !$omp end target teams distribute parallel do - ! CHECK: omp.task + ! CHECK: omp.target ! CHECK-SAME: if({{.*}}) - !$omp task if(.true.) - !$omp end task + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do if(.true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do - ! CHECK: omp.task + ! CHECK: omp.target ! CHECK-SAME: if({{.*}}) - !$omp task if(task: .true.) - !$omp end task + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do if(target: .true.) if(teams: .false.) if(parallel: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do if(target: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do if(teams: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do if(parallel: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do simd + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do simd if(.true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do simd if(target: .true.) if(teams: .false.) if(parallel: .true.) if(simd: .false.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do simd if(target: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do simd if(teams: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute parallel do simd if(parallel: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute parallel do simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute simd + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute simd if(.true.) + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute simd if(target: .true.) if(teams: .false.) if(simd: .false.) + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute simd if(target: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams distribute simd if(teams: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp target teams distribute simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS + ! ---------------------------------------------------------------------------- + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams + i = 1 + !$omp end target teams + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + !$omp target teams if(.true.) + i = 1 + !$omp end target teams + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + !$omp target teams if(target: .true.) if(teams: .false.) + i = 1 + !$omp end target teams + + ! CHECK: omp.target + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp target teams if(target: .true.) + i = 1 + !$omp end target teams + + ! CHECK: omp.target + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + !$omp target teams if(teams: .true.) + i = 1 + !$omp end target teams + + ! ---------------------------------------------------------------------------- + ! TASK + ! ---------------------------------------------------------------------------- + ! CHECK: omp.task + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp task + !$omp end task + + ! CHECK: omp.task + ! CHECK-SAME: if({{.*}}) + !$omp task if(.true.) + !$omp end task + + ! CHECK: omp.task + ! CHECK-SAME: if({{.*}}) + !$omp task if(task: .true.) + !$omp end task + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE + ! ---------------------------------------------------------------------------- + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute + do i = 1, 10 + end do + !$omp end teams distribute + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute if(.true.) + do i = 1, 10 + end do + !$omp end teams distribute + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute if(teams: .true.) + do i = 1, 10 + end do + !$omp end teams distribute + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE PARALLEL DO + ! ---------------------------------------------------------------------------- + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute parallel do + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do if(.true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do if(teams: .true.) if(parallel: .false.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute parallel do if(teams: .true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do if(parallel: .true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute parallel do simd + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do simd if(.true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do simd if(teams: .false.) if(parallel: .true.) if(simd: .false.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute parallel do simd if(teams: .true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute parallel do simd if(parallel: .true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.parallel + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute parallel do simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute simd + do i = 1, 10 + end do + !$omp end teams distribute simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute simd if(.true.) + do i = 1, 10 + end do + !$omp end teams distribute simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute simd if(teams: .true.) if(simd: .false.) + do i = 1, 10 + end do + !$omp end teams distribute simd + + ! CHECK: omp.teams + ! CHECK-SAME: if({{.*}}) + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + !$omp teams distribute simd if(teams: .true.) + do i = 1, 10 + end do + !$omp end teams distribute simd + + ! CHECK: omp.teams + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.distribute + ! CHECK-NOT: if({{.*}}) + ! CHECK-SAME: { + ! CHECK: omp.simdloop + ! CHECK-SAME: if({{.*}}) + !$omp teams distribute simd if(simd: .true.) + do i = 1, 10 + end do + !$omp end teams distribute simd ! ---------------------------------------------------------------------------- ! TEAMS diff --git a/flang/test/Lower/OpenMP/FIR/loop-combined.f90 b/flang/test/Lower/OpenMP/FIR/loop-combined.f90 index 117f7d625270ec..dec953ebcc8a67 100644 --- a/flang/test/Lower/OpenMP/FIR/loop-combined.f90 +++ b/flang/test/Lower/OpenMP/FIR/loop-combined.f90 @@ -6,19 +6,51 @@ program main integer :: i - ! TODO When DISTRIBUTE, TASKLOOP and TEAMS are supported add: - ! - DISTRIBUTE PARALLEL DO SIMD - ! - DISTRIBUTE PARALLEL DO - ! - DISTRIBUTE SIMD - ! - TARGET TEAMS DISTRIBUTE PARALLEL DO SIMD - ! - TARGET TEAMS DISTRIBUTE PARALLEL DO - ! - TARGET TEAMS DISTRIBUTE SIMD - ! - TARGET TEAMS DISTRIBUTE - ! - TASKLOOP SIMD - ! - TEAMS DISTRIBUTE PARALLEL DO SIMD - ! - TEAMS DISTRIBUTE PARALLEL DO - ! - TEAMS DISTRIBUTE SIMD - ! - TEAMS DISTRIBUTE + ! TODO TASKLOOP SIMD + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.simdloop + !$omp distribute parallel do simd + do i = 1, 10 + end do + !$omp end distribute parallel do simd + + !$omp end teams + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE PARALLEL DO + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.wsloop + !$omp distribute parallel do + do i = 1, 10 + end do + !$omp end distribute parallel do + + !$omp end teams + + ! ---------------------------------------------------------------------------- + ! DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + !$omp teams + + ! CHECK: omp.distribute + ! CHECK: omp.simdloop + !$omp distribute simd + do i = 1, 10 + end do + !$omp end distribute simd + + !$omp end teams ! ---------------------------------------------------------------------------- ! DO SIMD @@ -71,6 +103,60 @@ program main end do !$omp end target parallel do + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.target + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.simdloop + !$omp target teams distribute parallel do simd + do i = 1, 10 + end do + !$omp end target teams distribute parallel do simd + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE PARALLEL DO + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.target + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.wsloop + !$omp target teams distribute parallel do + do i = 1, 10 + end do + !$omp end target teams distribute parallel do + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.target + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.simdloop + !$omp target teams distribute simd + do i = 1, 10 + end do + !$omp end target teams distribute simd + + ! ---------------------------------------------------------------------------- + ! TARGET TEAMS DISTRIBUTE + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.target + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.wsloop + !$omp target teams distribute + do i = 1, 10 + end do + !$omp end target teams distribute + ! ---------------------------------------------------------------------------- ! TARGET SIMD ! ---------------------------------------------------------------------------- @@ -80,4 +166,54 @@ program main do i = 1, 10 end do !$omp end target simd + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE PARALLEL DO SIMD + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.simdloop + !$omp teams distribute parallel do simd + do i = 1, 10 + end do + !$omp end teams distribute parallel do simd + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE PARALLEL DO + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.parallel + ! CHECK: omp.wsloop + !$omp teams distribute parallel do + do i = 1, 10 + end do + !$omp end teams distribute parallel do + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE SIMD + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.simdloop + !$omp teams distribute simd + do i = 1, 10 + end do + !$omp end teams distribute simd + + ! ---------------------------------------------------------------------------- + ! TEAMS DISTRIBUTE + ! ---------------------------------------------------------------------------- + + ! CHECK: omp.teams + ! CHECK: omp.distribute + ! CHECK: omp.wsloop + !$omp teams distribute + do i = 1, 10 + end do + !$omp end teams distribute end program main diff --git a/flang/test/Lower/OpenMP/distribute.f90 b/flang/test/Lower/OpenMP/distribute.f90 new file mode 100644 index 00000000000000..dcfdeb25ded937 --- /dev/null +++ b/flang/test/Lower/OpenMP/distribute.f90 @@ -0,0 +1,117 @@ +! RUN: %flang_fc1 -emit-hlfir -fopenmp %s -o - | FileCheck %s + +! CHECK-LABEL: func @_QPdistribute_simple +subroutine distribute_simple() + ! CHECK: omp.teams + !$omp teams + + ! CHECK: omp.distribute + !$omp distribute + + ! CHECK: omp.wsloop + do i = 1, 10 + call foo() + ! CHECK: omp.yield + end do + + ! CHECK: omp.terminator + !$omp end distribute + + ! CHECK: omp.terminator + !$omp end teams +end subroutine distribute_simple + +!=============================================================================== +! `dist_schedule` clause +!=============================================================================== + +! CHECK-LABEL: func @_QPdistribute_dist_schedule +! CHECK-SAME: %[[X_ARG:.*]]: !fir.ref +subroutine distribute_dist_schedule(x) + ! CHECK: %[[X_REF:.*]]:2 = hlfir.declare %[[X_ARG]] + integer, intent(in) :: x + + ! CHECK: omp.teams + !$omp teams + + ! STATIC SCHEDULE, CONSTANT CHUNK SIZE + + ! CHECK: %[[CONST_CHUNK_SIZE:.*]] = arith.constant 5 : i32 + ! CHECK: omp.distribute + ! CHECK-SAME: dist_schedule_static + ! CHECK-SAME: chunk_size(%[[CONST_CHUNK_SIZE]] : i32) + !$omp distribute dist_schedule(static, 5) + + ! CHECK: omp.wsloop + do i = 1, 10 + call foo() + ! CHECK: omp.yield + end do + + ! CHECK: omp.terminator + !$omp end distribute + + ! STATIC SCHEDULE, VARIABLE CHUNK SIZE + + ! CHECK: %[[X:.*]] = fir.load %[[X_REF]]#0 + ! CHECK: omp.distribute + ! CHECK-SAME: dist_schedule_static + ! CHECK-SAME: chunk_size(%[[X]] : i32) + !$omp distribute dist_schedule(static, x) + + ! CHECK: omp.wsloop + do i = 1, 10 + call foo() + ! CHECK: omp.yield + end do + + ! CHECK: omp.terminator + !$omp end distribute + + ! STATIC SCHEDULE, NO CHUNK SIZE + + ! CHECK: omp.distribute + ! CHECK-SAME: dist_schedule_static + ! CHECK-NOT: chunk_size + !$omp distribute dist_schedule(static) + + ! CHECK: omp.wsloop + do i = 1, 10 + call foo() + ! CHECK: omp.yield + end do + + ! CHECK: omp.terminator + !$omp end distribute + + ! CHECK: omp.terminator + !$omp end teams +end subroutine distribute_dist_schedule + +!=============================================================================== +! `allocate` clause +!=============================================================================== + +! CHECK-LABEL: func @_QPdistribute_allocate +subroutine distribute_allocate() + use omp_lib + integer :: x + ! CHECK: omp.teams + !$omp teams + + ! CHECK: omp.distribute + ! CHECK-SAME: allocate(%{{.+}} : i32 -> %{{.+}} : !fir.ref) + !$omp distribute allocate(omp_high_bw_mem_alloc: x) private(x) + + ! CHECK: omp.wsloop + do i = 1, 10 + x = i + ! CHECK: omp.yield + end do + + ! CHECK: omp.terminator + !$omp end distribute + + ! CHECK: omp.terminator + !$omp end teams +end subroutine distribute_allocate