From 60730599f25c33254f1419b5ca0a092458ed53b0 Mon Sep 17 00:00:00 2001 From: Maximilian Kruse Date: Fri, 27 Jan 2023 09:04:07 +0100 Subject: [PATCH 1/5] update version number --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 1f46e4c..6a46247 100644 --- a/setup.py +++ b/setup.py @@ -11,7 +11,7 @@ setup( name='slider', - version='0.6.0', + version='0.7.0', description='Utilities for working with osu! files and data', author='Joe Jevnik', author_email='joejev@gmail.com', From 5abf62699c9132eda47343c876eddc60c6212aca Mon Sep 17 00:00:00 2001 From: Maximilian Kruse Date: Fri, 27 Jan 2023 09:10:54 +0100 Subject: [PATCH 2/5] Add description to true_tick_points --- slider/beatmap.py | 1 + 1 file changed, 1 insertion(+) diff --git a/slider/beatmap.py b/slider/beatmap.py index d21597b..55b1cac 100644 --- a/slider/beatmap.py +++ b/slider/beatmap.py @@ -663,6 +663,7 @@ def tick_points(self): @lazyval def true_tick_points(self): + """The position and time of each slider tick. This accounts for the legacy last tick offset.""" tick_points = self.tick_points # curve() takes in a percentage of how far along we want the point. # Take away the offset from the total length of the slider to get From 9792acdc044ef6443ff71b8648833e1c27b054df Mon Sep 17 00:00:00 2001 From: Maximilian Kruse Date: Fri, 27 Jan 2023 11:04:07 +0100 Subject: [PATCH 3/5] fix line length in docstring --- slider/beatmap.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/slider/beatmap.py b/slider/beatmap.py index 55b1cac..c7c4040 100644 --- a/slider/beatmap.py +++ b/slider/beatmap.py @@ -663,7 +663,8 @@ def tick_points(self): @lazyval def true_tick_points(self): - """The position and time of each slider tick. This accounts for the legacy last tick offset.""" + """The position and time of each slider tick. This accounts for + the legacy last tick offset.""" tick_points = self.tick_points # curve() takes in a percentage of how far along we want the point. # Take away the offset from the total length of the slider to get From 7f599215b730d2be43fa75154a6d36a9e1f92cfd Mon Sep 17 00:00:00 2001 From: Maximilian Kruse Date: Fri, 27 Jan 2023 11:05:59 +0100 Subject: [PATCH 4/5] remove whitespace --- slider/beatmap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slider/beatmap.py b/slider/beatmap.py index c7c4040..55556f1 100644 --- a/slider/beatmap.py +++ b/slider/beatmap.py @@ -663,7 +663,7 @@ def tick_points(self): @lazyval def true_tick_points(self): - """The position and time of each slider tick. This accounts for + """The position and time of each slider tick. This accounts for the legacy last tick offset.""" tick_points = self.tick_points # curve() takes in a percentage of how far along we want the point. From 4da59b0579f75f7f5b796730567efe69d6088d01 Mon Sep 17 00:00:00 2001 From: Liam DeVoe Date: Sat, 28 Jan 2023 14:36:29 -0500 Subject: [PATCH 5/5] link to lazer last tick --- slider/beatmap.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/slider/beatmap.py b/slider/beatmap.py index 55556f1..569a2a4 100644 --- a/slider/beatmap.py +++ b/slider/beatmap.py @@ -664,7 +664,10 @@ def tick_points(self): @lazyval def true_tick_points(self): """The position and time of each slider tick. This accounts for - the legacy last tick offset.""" + the legacy last tick offset. + + See also https://github.com/ppy/osu/blob/5a1940facf2649bc6b2892965c27b8 + c62a41988f/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L71-L93""" tick_points = self.tick_points # curve() takes in a percentage of how far along we want the point. # Take away the offset from the total length of the slider to get