Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] User isolation #16

Open
iiiCpu opened this issue Jul 31, 2024 · 1 comment
Open

[Suggestion] User isolation #16

iiiCpu opened this issue Jul 31, 2024 · 1 comment

Comments

@iiiCpu
Copy link

iiiCpu commented Jul 31, 2024

Hey!

Let's say, your mod is for isolation admin from guests. Leaving aside all magnificent features like nodes, checkpoint, lora and workflow isolation I can dream on about, there's one feature that should be rather simple to implement. Isolate input\output\temp folders.

The idea is simple: admin can use <ComfyUI>\input, <ComfyUI>\output and <ComfyUI>\temp the usual way. For each guest a set of folders with their session_id is created, and all files are put into this folders.

Why? Despite giving some sort of isolation, guest mode, in fact, does not isolate user space. So, one can access any input or output file with raw request. But this sort of access is limited by built-in toolset in folder_path.py. And it doesn't need much changes for rather high level of privacy.

Of course, there will still be many flaws and holes like VHS Load Path, but it is rather solid starting point.

@iiiCpu
Copy link
Author

iiiCpu commented Jul 31, 2024

With that being said, it's possible to override every other path. And to use symlinks to give access to needed files. Still, rather big list of changes for now, better take one step at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant