From 7c7fa36235ccb455b3f1a511b4d44120b62a0d61 Mon Sep 17 00:00:00 2001 From: bittersweet1999 <148421775+bittersweet1999@users.noreply.github.com> Date: Wed, 11 Sep 2024 13:32:34 +0800 Subject: [PATCH] [Feature] add support for internal Followbench (#1511) * fix pip version * fix pip version * add internal followbench * add internal followbench * fix lint * fix lint --- .../subjective/fofo/fofo_bilingual_judge.py | 34 +++- .../followbench/followbench_llmeval.py | 63 +++++++ .../subjective/fofo/fofo_bilingual_judge.py | 34 +++- .../followbench/followbench_llmeval.py | 63 +++++++ opencompass/datasets/subjective/__init__.py | 1 + .../datasets/subjective/followbench.py | 163 ++++++++++++++++++ .../summarizers/subjective/__init__.py | 1 + .../summarizers/subjective/followbench.py | 149 ++++++++++++++++ opencompass/summarizers/subjective/utils.py | 54 ++++++ 9 files changed, 560 insertions(+), 2 deletions(-) create mode 100644 configs/datasets/subjective/followbench/followbench_llmeval.py create mode 100644 opencompass/configs/datasets/subjective/followbench/followbench_llmeval.py create mode 100644 opencompass/datasets/subjective/followbench.py create mode 100644 opencompass/summarizers/subjective/followbench.py diff --git a/configs/datasets/subjective/fofo/fofo_bilingual_judge.py b/configs/datasets/subjective/fofo/fofo_bilingual_judge.py index ed221204b..089fd101e 100644 --- a/configs/datasets/subjective/fofo/fofo_bilingual_judge.py +++ b/configs/datasets/subjective/fofo/fofo_bilingual_judge.py @@ -15,7 +15,7 @@ 'fofo_test_prompts', 'fofo_test_prompts_cn', ] -base_prompt = """ +base_prompt_en = """ I would like you to create a leaderboard that evaluates the correctness of the format of answers from various large language models. To accomplish this, you will need to analyze the text prompts given to the models and their corresponding answers. Specifically, please ensure that your evaluation outputs are properly formatted as a json string. I will provide both the prompts and the responses for this purpose. Here is the prompt: @@ -45,9 +45,41 @@ Please note that your response should be a properly formatted JSON string and should not contain any additional content. We will load it directly as a JSON string in Python. """ + +base_prompt_cn = """ +我希望你创建一个排行榜，用于评估来自各种大型语言模型的回答格式的正确性。为了完成这个任务，你将需要分析给模型的文本提示以及它们对应的回答。具体来说，请确保你的评估输出正确地格式化为JSON字符串。我将为此提供提示和回答。 +以下是提示内容： +{ + "instruction": "{question}", +} +以下是模型的输出结果： +[ + { + "model": "model", + "answer": "{prediction}" + }, +] +请通过检查模型回答是否符合提示中声明的格式规范来评估模型回答的格式。进行彻底的格式检查，并提供格式正确或错误的详细解释。你的反馈应包括模型的名称，接着是格式正确性的状态，用'1'表示正确，'0'表示错误。将你的推理以每个评估模型的单个字符串中的 bullet 点形式呈现。换句话说，你应该生成以下输出： +```json +[ + { + 'model': <模型名称>, + 'format_correctness': <正确性>, + 'reasons': <格式正确性的原因> + } +] +``` +请注意，你的回答应是一个正确格式化的JSON字符串，不应包含任何额外的内容。我们将在Python中直接将其作为JSON字符串加载。 +""" + + fofo_datasets = [] for _name in subjective_all_sets: + if '_cn' in _name: + base_prompt = base_prompt_cn + else: + base_prompt = base_prompt_en subjective_infer_cfg = dict( prompt_template=dict( type=PromptTemplate, diff --git a/configs/datasets/subjective/followbench/followbench_llmeval.py b/configs/datasets/subjective/followbench/followbench_llmeval.py new file mode 100644 index 000000000..0733340ed --- /dev/null +++ b/configs/datasets/subjective/followbench/followbench_llmeval.py @@ -0,0 +1,63 @@ +from opencompass.openicl.icl_prompt_template import PromptTemplate +from opencompass.openicl.icl_retriever import ZeroRetriever +from opencompass.openicl.icl_inferencer import GenInferencer +from opencompass.openicl.icl_evaluator import LMEvaluator +from opencompass.datasets import FollowBenchDataset +from opencompass.summarizers import FollowBenchSummarizer + +subjective_reader_cfg = dict( + input_columns=['instruction', 'judge_prompt',], + output_column='judge', + ) + +subjective_all_sets = [ + 'followbench_llmeval_cn', 'followbench_llmeval_en', +] +data_path ='data/subjective/followbench/converted_data' + +followbench_llmeval_dataset = [] + +for _name in subjective_all_sets: + subjective_infer_cfg = dict( + prompt_template=dict( + type=PromptTemplate, + template=dict(round=[ + dict( + role='HUMAN', + prompt='{instruction}' + ), + ]), + ), + retriever=dict(type=ZeroRetriever), + inferencer=dict(type=GenInferencer, max_out_len=2048), + ) + + subjective_eval_cfg = dict( + evaluator=dict( + type=LMEvaluator, + prompt_template=dict( + type=PromptTemplate, + template=dict(round=[ + dict( + role='HUMAN', + prompt = '{judge_prompt}' + ), + ]), + ), + ), + pred_role='BOT', + ) + + followbench_llmeval_dataset.append( + dict( + abbr=f'{_name}', + type=FollowBenchDataset, + path=data_path, + name=_name, + mode='singlescore', + cate='llm', + reader_cfg=subjective_reader_cfg, + infer_cfg=subjective_infer_cfg, + eval_cfg=subjective_eval_cfg, + summarizer = dict(type=FollowBenchSummarizer,) + )) diff --git a/opencompass/configs/datasets/subjective/fofo/fofo_bilingual_judge.py b/opencompass/configs/datasets/subjective/fofo/fofo_bilingual_judge.py index ed221204b..089fd101e 100644 --- a/opencompass/configs/datasets/subjective/fofo/fofo_bilingual_judge.py +++ b/opencompass/configs/datasets/subjective/fofo/fofo_bilingual_judge.py @@ -15,7 +15,7 @@ 'fofo_test_prompts', 'fofo_test_prompts_cn', ] -base_prompt = """ +base_prompt_en = """ I would like you to create a leaderboard that evaluates the correctness of the format of answers from various large language models. To accomplish this, you will need to analyze the text prompts given to the models and their corresponding answers. Specifically, please ensure that your evaluation outputs are properly formatted as a json string. I will provide both the prompts and the responses for this purpose. Here is the prompt: @@ -45,9 +45,41 @@ Please note that your response should be a properly formatted JSON string and should not contain any additional content. We will load it directly as a JSON string in Python. """ + +base_prompt_cn = """ +我希望你创建一个排行榜，用于评估来自各种大型语言模型的回答格式的正确性。为了完成这个任务，你将需要分析给模型的文本提示以及它们对应的回答。具体来说，请确保你的评估输出正确地格式化为JSON字符串。我将为此提供提示和回答。 +以下是提示内容： +{ + "instruction": "{question}", +} +以下是模型的输出结果： +[ + { + "model": "model", + "answer": "{prediction}" + }, +] +请通过检查模型回答是否符合提示中声明的格式规范来评估模型回答的格式。进行彻底的格式检查，并提供格式正确或错误的详细解释。你的反馈应包括模型的名称，接着是格式正确性的状态，用'1'表示正确，'0'表示错误。将你的推理以每个评估模型的单个字符串中的 bullet 点形式呈现。换句话说，你应该生成以下输出： +```json +[ + { + 'model': <模型名称>, + 'format_correctness': <正确性>, + 'reasons': <格式正确性的原因> + } +] +``` +请注意，你的回答应是一个正确格式化的JSON字符串，不应包含任何额外的内容。我们将在Python中直接将其作为JSON字符串加载。 +""" + + fofo_datasets = [] for _name in subjective_all_sets: + if '_cn' in _name: + base_prompt = base_prompt_cn + else: + base_prompt = base_prompt_en subjective_infer_cfg = dict( prompt_template=dict( type=PromptTemplate, diff --git a/opencompass/configs/datasets/subjective/followbench/followbench_llmeval.py b/opencompass/configs/datasets/subjective/followbench/followbench_llmeval.py new file mode 100644 index 000000000..0733340ed --- /dev/null +++ b/opencompass/configs/datasets/subjective/followbench/followbench_llmeval.py @@ -0,0 +1,63 @@ +from opencompass.openicl.icl_prompt_template import PromptTemplate +from opencompass.openicl.icl_retriever import ZeroRetriever +from opencompass.openicl.icl_inferencer import GenInferencer +from opencompass.openicl.icl_evaluator import LMEvaluator +from opencompass.datasets import FollowBenchDataset +from opencompass.summarizers import FollowBenchSummarizer + +subjective_reader_cfg = dict( + input_columns=['instruction', 'judge_prompt',], + output_column='judge', + ) + +subjective_all_sets = [ + 'followbench_llmeval_cn', 'followbench_llmeval_en', +] +data_path ='data/subjective/followbench/converted_data' + +followbench_llmeval_dataset = [] + +for _name in subjective_all_sets: + subjective_infer_cfg = dict( + prompt_template=dict( + type=PromptTemplate, + template=dict(round=[ + dict( + role='HUMAN', + prompt='{instruction}' + ), + ]), + ), + retriever=dict(type=ZeroRetriever), + inferencer=dict(type=GenInferencer, max_out_len=2048), + ) + + subjective_eval_cfg = dict( + evaluator=dict( + type=LMEvaluator, + prompt_template=dict( + type=PromptTemplate, + template=dict(round=[ + dict( + role='HUMAN', + prompt = '{judge_prompt}' + ), + ]), + ), + ), + pred_role='BOT', + ) + + followbench_llmeval_dataset.append( + dict( + abbr=f'{_name}', + type=FollowBenchDataset, + path=data_path, + name=_name, + mode='singlescore', + cate='llm', + reader_cfg=subjective_reader_cfg, + infer_cfg=subjective_infer_cfg, + eval_cfg=subjective_eval_cfg, + summarizer = dict(type=FollowBenchSummarizer,) + )) diff --git a/opencompass/datasets/subjective/__init__.py b/opencompass/datasets/subjective/__init__.py index 077db3797..96d449272 100644 --- a/opencompass/datasets/subjective/__init__.py +++ b/opencompass/datasets/subjective/__init__.py @@ -9,6 +9,7 @@ from .corev2 import Corev2Dataset # noqa: F401, F403 from .creationbench import CreationBenchDataset # noqa: F401, F403 from .fofo import FofoDataset # noqa: F401, F403 +from .followbench import FollowBenchDataset # noqa: F401, F403 from .information_retrival import IRDataset # noqa: F401, F403 from .mtbench import MTBenchDataset # noqa: F401, F403 from .mtbench101 import MTBench101Dataset # noqa: F401, F403 diff --git a/opencompass/datasets/subjective/followbench.py b/opencompass/datasets/subjective/followbench.py new file mode 100644 index 000000000..b814d30b9 --- /dev/null +++ b/opencompass/datasets/subjective/followbench.py @@ -0,0 +1,163 @@ +# flake8: noqa +import json +import os.path as osp +import re + +from datasets import Dataset + +from opencompass.openicl.icl_evaluator import BaseEvaluator +from opencompass.registry import LOAD_DATASET +from opencompass.utils import get_data_path + +from ..base import BaseDataset + + +def check_match(target, generation): + pattern_str = target.replace('{{', + '{').replace('}}', + '}').replace('{answer}', '.*') + pattern_str = re.escape(pattern_str).replace('\\.\\*', '.*') + match = re.fullmatch(pattern_str, generation) + return bool(match) + + +@LOAD_DATASET.register_module() +class FollowBenchDataset(BaseDataset): + + def load(self, path: str, name: str, cate: str, *args, **kwargs): + + path = get_data_path(path, local_mode=True) + filename = osp.join(path, f'{name}.json') + raw_data = [] + raw_data = [] + with open(filename, 'r', encoding='utf-8') as f: + data = json.load(f) + for item in data: + if cate == 'llm': + raw_data.append({ + 'instruction': item['instruction'], + 'judge_prompt': item['judge_prompt'], + 'judge': item + }) + elif cate == 'rule': + raw_data.append({ + 'instruction': item['instruction'], + 'judge': item + }) + else: + raise NotImplementedError( + f"Category '{cate}' is not implemented.") + + dataset = Dataset.from_list(raw_data) + return dataset + + +class FollowBenchEvaluator(BaseEvaluator): + """Evaluator for followbench rule-based eval.""" + + def __init__(self, num_workers=16) -> None: + self.num_workers = num_workers + + def score_single(self, pred, refer): + generated_code = pred + + # get current dir because we will enter a temp dir to + # execute generated code + cwd = os.getcwd() + + def chdir_return(cwd, return_value): + os.chdir(cwd) + return return_value + + # we create a tempdir to execute each generated program + with tempfile.TemporaryDirectory() as tempdir_name: + + tempdir_name = Path(tempdir_name) + # copy all files and data dependencies from + shutil.copytree(refer['problem_path'], + tempdir_name, + dirs_exist_ok=True) + # generated outputs will be put into `result` + os.mkdir(tempdir_name / 'result') + + program = refer['code_context'].replace('[insert]', generated_code) + with open(tempdir_name / 'program.py', 'w', encoding='UTF-8') as f: + f.write(program) + + # enter into the tempdir to execute + os.chdir(tempdir_name) + + execution_status = [] + # a question may not have test case but we can still execute and + # see if there is error + test_cnt = max(1, int(refer['test_case_cnt'])) + for i in range(1, test_cnt + 1): + # notice this command, e.g., you may need to + # replace `python` with `python3` + cmd_text = f'python program.py --test_case {i}' + time_limit = 60 # should not change the official time_limit + cmd = Command(cmd_text, ) + exit_code = cmd.run( + timeout=time_limit) # 0 if there is no error + execution_status.append(exit_code) + + # return if execution error + if sum(execution_status) > 0: + return chdir_return(cwd, False) + + # loading testing code as a module + test_module = import_source_file(tempdir_name / 'test_code.py', + 'test_code') + pass_flag = True + + if int(refer['test_type']) == 3: + # stringTest parses the generated code into AST + # and check AST components + # if there is static error, stringTest may raise an exception + generated_code = generated_code.split('\n') + for line in generated_code: + if 'print' in line and '#' not in line.split('print'): + generated_code.remove(line) + generated_code = '\n'.join(generated_code) + try: + pass_flag = test_module.stringTest(generated_code) + except Exception: + # return False if stringTest error + return chdir_return(cwd, False) + + test_cnt = max(int(refer['test_case_cnt']), 1) + for i in range(1, test_cnt + 1): + try: + ans = pickle.load(open(f'ans/ans{i}.pkl', 'rb')) + # loading the generated output might still raise Exception + # if the generated code is not correct + result = pickle.load(open(f'result/result_{i}.pkl', 'rb')) + pass_flag = test_module.test(result, ans) == 1 + except Exception: + # return False if stringTest error + return chdir_return(cwd, False) + + return chdir_return(cwd, pass_flag) + + def score(self, predictions, references): + results = {'example': {'accuracy': [0, 0, 0, 0, 0], 'num': 0}} + for prediction, reference in zip(predictions, references): + if reference['category'] == 'example': + results['example']['num'] += 1 + template = reference['target'].replace('{instruction}\n', '') + match_result = check_match(template, prediction) + print(match_result) + results['example']['accuracy'][reference['level'] - + 1] += match_result + results['example']['accuracy'] = [ + round(acc / (results['example']['num'] // 5), 2) + for acc in results['example']['accuracy'] + ] + ######## Still not finished for rule-based evaluation + + # Each process changes cwd, need to use multi-processing + with ProcessPoolExecutor(self.num_workers) as executor: + passed = sum( + list(executor.map(self.score_single, predictions, references))) + + return {'accuracy': passed / total} diff --git a/opencompass/summarizers/subjective/__init__.py b/opencompass/summarizers/subjective/__init__.py index f6093566f..6565d5c89 100644 --- a/opencompass/summarizers/subjective/__init__.py +++ b/opencompass/summarizers/subjective/__init__.py @@ -10,6 +10,7 @@ from .creationbench import CreationBenchSummarizer from .flames import FlamesSummarizer from .fofo import FofoSummarizer +from .followbench import FollowBenchSummarizer from .mtbench import MTBenchSummarizer from .mtbench101 import MTBench101Summarizer from .multiround import MultiroundSummarizer diff --git a/opencompass/summarizers/subjective/followbench.py b/opencompass/summarizers/subjective/followbench.py new file mode 100644 index 000000000..1614dfa58 --- /dev/null +++ b/opencompass/summarizers/subjective/followbench.py @@ -0,0 +1,149 @@ +# flake8: noqa: E501 +import csv +import os +import os.path as osp +import re +import statistics +from collections import defaultdict +from datetime import datetime + +import numpy as np +from mmengine import ConfigDict + +try: + from prettytable import from_csv +except ImportError: + from_csv = None + +from opencompass.utils import model_abbr_from_cfg + +from .subjective_post_process import post_process_autoj, post_process_judgelm +from .utils import get_judgeanswer_and_reference_update, get_outdir + + +def post_process_followbench(item): + generation, level = item['prediction'], item['gold']['level'] + try: + satisfy = generation.strip('```').strip().split('\n')[-1] + + if level == 1: + if 'YES' in satisfy: + return 1, 1 + elif 'NO' in satisfy: + return 0, 0 + else: + raise Exception('Invalid evaluation for level 1.') + else: + satisfy_list = re.search(r'\[.*\]', satisfy) + if satisfy_list: + satisfy_list = eval(satisfy_list.group()) + if len(satisfy_list) == level: + num_true = 0 + for i in satisfy_list: + if i == 'YES' or i == 'True': + num_true += 1 + elif i in [ + 'NO', 'False', 'PARTIAL', 'MAYBE', 'UNKNOWN', + 'N/A' + ]: + num_true += 0 + else: + raise Exception('Invalid element in the list.') + return int(num_true == level), num_true / level + else: + raise Exception('Invalid number of elements in the list.') + else: + raise Exception('Invalid list that cannot be parsed.') + + except Exception as e: + return -1, -1 + + +def get_scores(judged_answers, references): + results = [[0, 0, 0, 0, 0], [0, 0, 0, 0, 0]] + n_group = len(judged_answers) // 5 + n_groups = [n_group] * 5 + + for judged_answer, reference in zip(judged_answers, references): + if judged_answer[0] == -1: + n_groups[reference['level'] - 1] -= 1 + else: + results[0][reference['level'] - 1] += judged_answer[0] + results[1][reference['level'] - 1] += judged_answer[1] + + for i in range(len(results)): + for j in range(len(results[i])): + if n_groups[j] != 0: + results[i][j] = results[i][j] / n_groups[j] + else: + results[i][j] = 0 + temp_dict = { + 'HSR_AVG': statistics.mean(results[0]), + 'SSR_AVG': statistics.mean(results[1]) + } + for idx, s in enumerate(results[0]): + temp_dict[f'HSR_L{idx+1}'] = s + for idx, s in enumerate(results[1]): + temp_dict[f'SSR_L{idx+1}'] = s + + return temp_dict + + +class FollowBenchSummarizer: + """Do the subjectivity analyze based on evaluation results. + + Args: + config (ConfigDict): The configuration object of the evaluation task. + It's expected to be filled out at runtime. + """ + + def __init__(self, config: ConfigDict) -> None: + self.tasks = [] + self.cfg = config + self.eval_model_cfgs = self.cfg['eval']['partitioner']['models'] + self.eval_model_abbrs = [ + model_abbr_from_cfg(model) for model in self.eval_model_cfgs + ] + self.judge_models = self.cfg.get('judge_models', None) + + self.judge_function = post_process_followbench + + def summarize(self, + time_str: str = datetime.now().strftime('%Y%m%d_%H%M%S')): + """Summarize the subjectivity analysis based on evaluation results. + + Args: + time_str (str): Timestamp for file naming. + + Returns: + pd.DataFrame: The summary results. + """ + all_scores = {} + for judge_model in self.judge_models: + score_by_judgemodel = {} + judge_abbr = model_abbr_from_cfg(judge_model) + dataset_cfgs = self.cfg['datasets'] + dataset = dataset_cfgs[0] # Alignbench just have only one subfile + output_dir, results_folder = get_outdir(self.cfg, time_str) + + fout = osp.join(output_dir, + 'followbench-judged-by--' + judge_abbr + '.csv') + + for eval_model_abbr in self.eval_model_abbrs: + subdir = eval_model_abbr + '_judged-by--' + judge_abbr + subdir_path = os.path.join(results_folder, subdir) + model = eval_model_abbr + if os.path.isdir(subdir_path): + judged_answers, references = get_judgeanswer_and_reference_update( + dataset, subdir_path, self.judge_function) + if len(judged_answers) == 0: + score_by_judgemodel[model] = None + continue + scores = get_scores(judged_answers, references) + score_by_judgemodel[model] = scores + else: + score_by_judgemodel[model] = None + print(subdir_path + ' is not exist! please check!') + + all_scores[judge_abbr] = score_by_judgemodel + return {'followbench': all_scores} diff --git a/opencompass/summarizers/subjective/utils.py b/opencompass/summarizers/subjective/utils.py index fd636059c..42ea504b9 100644 --- a/opencompass/summarizers/subjective/utils.py +++ b/opencompass/summarizers/subjective/utils.py @@ -73,3 +73,57 @@ def get_judgeanswer_and_reference(dataset, subdir_path, post_process): ) print('*' * 100) return judged_answers, references + + +def get_judgeanswer_and_reference_update(dataset, subdir_path, post_process): + """Extract judgements (scores) and references. + + Args: + dataset (ConfigDict): Dataset config. + subdir_path (str): Model path in results dir. + post_process (function): The pre-defined extract function. + """ + dataset_abbr = dataset_abbr_from_cfg(dataset) + filename = osp.join(subdir_path, dataset_abbr + '.json') + partial_filename = osp.join(subdir_path, dataset_abbr + '_0.json') + if osp.exists(osp.realpath(filename)): + result = mmengine.load(filename) + elif osp.exists(osp.realpath(partial_filename)): + filename = partial_filename + result = {} + i = 1 + partial_dict_flag = 0 + while osp.exists(osp.realpath(filename)): + res = mmengine.load(filename) + for k, v in res.items(): + result[partial_dict_flag] = v + partial_dict_flag += 1 + filename = osp.join(subdir_path, + dataset_abbr + '_' + str(i) + '.json') + i += 1 + else: + result = {} + + if len(result) == 0: + print('*' * 100) + print('There are no results for ' + filename + ' or ' + + partial_filename) + print('*' * 100) + + judged_answers = [] + references = [] + for k, v in result.items(): + processed_judge = post_process(v) + if processed_judge is not None: + judged_answers.append(processed_judge) + references.append(v['gold']) + # else: + # print(v['prediction']) + # print('-' * 128) + if len(judged_answers) <= 0.95 * len(result): + print('*' * 100) + print( + f'For your {filename} judge. Among {len(result)} judgements, successfully extracted {len(judged_answers)} judgements, please check!' + ) + print('*' * 100) + return judged_answers, references