Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loader while metadata is being fetched in Workflow Settings #3263

Open
S-ayanide opened this issue Oct 7, 2021 · 3 comments
Open

Add Loader while metadata is being fetched in Workflow Settings #3263

S-ayanide opened this issue Oct 7, 2021 · 3 comments

Comments

@S-ayanide
Copy link
Member

What happened: The Workflow Settings Component doesn't show a loader while the details of the workflow are being fetched due to slower networks, instead, it has an empty text field and a blank avatar.

What you expected to happen: The Stepper UI component should be loaded but the Text Field and the Avatar section should consist of a loader while the data is being fetched. Also, the Next button should be disabled while the fetch isn't completed.

How to reproduce it (as minimally and precisely as possible): Toggle throttle slow network on the browser and navigate to the Workflow Settings page.

@ZiadAliKhalifa
Copy link

Can I take this?

@punithnayak
Copy link
Contributor

Hey @S-ayanide can you assign me so that I can raise The pr
My previous contribution in Wikimedia Foundation
https://gerrit.wikimedia.org/r/q/punit

@punithnayak
Copy link
Contributor

Hey @S-ayanide when the network is offline we are getting the loader is seen
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants