Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash plugin support #35

Open
PoisonousJohn opened this issue Jan 12, 2017 · 5 comments
Open

Add flash plugin support #35

PoisonousJohn opened this issue Jan 12, 2017 · 5 comments
Labels
enhancement New feature or request

Comments

@PoisonousJohn
Copy link
Contributor

Flash is not working now

@timsueberkrueb
Copy link
Collaborator

QtWebEngine supports Flash.
See http://doc.qt.io/qt-5/qtwebengine-features.html#pepper-flash-player-plugin-support.
Haven't tested it yet, though.

@plfiorini
Copy link
Member

plfiorini commented Jan 12, 2017

Flash is really bad regarding security and stability, unfortunately some sites are still using it, the most notable being Facebook. Of course we should support Flash but it should be disabled by default.

@PoisonousJohn
Copy link
Contributor Author

PoisonousJohn commented Jan 12, 2017

I tried to add

Qt += webenginewidgets

and

QWebEngineSettings::defaultSettings()->setAttribute(QWebEngineSettings::PluginsEnabled, true)

and it's not working for me when I'm checking it here https://www.adobe.com/software/flash/about/

@timsueberkrueb
Copy link
Collaborator

@JohnPoison cool. We will need to handle it in a Oxide-compatible way (e.g. Qt += webenginewidgets only if QTWEBENGINE_ENABLED, same with the attribute).
I agree with @plfiorini it should be disabled by default.

@PoisonousJohn
Copy link
Contributor Author

PoisonousJohn commented Jan 12, 2017

Sure, it was just for test. I also agree that it should be disabled by default . But the problem is that it's not working and I can't understand why. Flash in DemoBrowser from Qt examples works on adobe test page. Yet it doesn't work on http://rutube.ru

@timsueberkrueb timsueberkrueb added the enhancement New feature or request label Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants