Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dell Active Pen #628

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Update Dell Active Pen #628

merged 2 commits into from
Jan 28, 2024

Conversation

Doomsdayrs
Copy link
Contributor

The Dell Active Pen is misconfigured in libwacom.stylus.

Firstly, The pen has 2 buttons.

Secondly "AES" pen does not properly illustrate what the pen is to the user.

The Dell Active Pen is misconfigured in `libwacom.stylus`.

Firstly, The pen has 2 buttons.

Secondly "AES" pen does not properly illustrate what the pen is to the user.
@whot
Copy link
Member

whot commented Jan 24, 2024

Firstly, The pen has 2 buttons.

2 actual buttons or 1 button + an eraser button? The latter doesn't count as button (iirc) since we can't re-map it, it's hardcoded for some specific behaviour that requires heuristics to undo and we'll likely never implement those. So even if the pen has 2 physical buttons, from libwacom's POV there's only one that is a real button.

@Doomsdayrs
Copy link
Contributor Author

Firstly, The pen has 2 buttons.

2 actual buttons or 1 button + an eraser button? The latter doesn't count as button (iirc) since we can't re-map it, it's hardcoded for some specific behaviour that requires heuristics to undo and we'll likely never implement those. So even if the pen has 2 physical buttons, from libwacom's POV there's only one that is a real button.

Thanks for the explanation!

I was confused why I only saw one button listed in the GNOME Settings UI, I shall take it there to help explain that to the user.


I hope the name change is okay?


Furthermore, I notice that the SVG defaults to this "basic" pen. Is there any way I can provide an SVG for my pen, I did not see documentation about it.

image

@whot
Copy link
Member

whot commented Jan 28, 2024

for stylistic reasons [1] the svgs for the syli are part of the gnome-control-center, so you'd need to add the pen there and then check the code on how the SVGs are being picked based on the current tool.

The name change is fine, let's hope this id is only used by Dell (if not, we'll have to change it back).

[1] the tablet SVGs are neutral-ish, the svgs for the pens were more specific to the gnome style, that's what I vaguely remember.

data/libwacom.stylus Outdated Show resolved Hide resolved
@whot whot merged commit e758973 into linuxwacom:master Jan 28, 2024
13 checks passed
@whot
Copy link
Member

whot commented Jan 28, 2024

Realised I can just fix the buttons line here, so let's do that. Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants