Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync release script with xf86-input-wacom #417

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

Pinglinux
Copy link
Member

This is to port Peter's update to the release.sh for xf86-input-wacom to input-wacom. Some minor adjustments were added to the last two patches:

Removal of "--moduleset case".

And merging of "if [ $? -ne 0 ]; then" with "if [ x"$configNum" = x0 ]; then".

Apparently the old way no longer works, so let's update with a
copy/paste from the examples.

Intentional switch to use --token because that's how you should be doing
releases anyway - with a temporary token that can be revoked after the
release is complete (and that also encodes the username).

https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release
Ported from xf86-input-wacon
Signed-off-by: Peter Hutterer <[email protected]>
Signed-off-by: Ping Cheng <[email protected]>
Might as well since we only ever release one module at a time with this
script.

Ported from xf86-input-wacon
Signed-off-by: Peter Hutterer <[email protected]>
Signed-off-by: Ping Cheng <[email protected]>
No longer hooked into anything so let's not pretend we have it.

Ported from xf86-input-wacom
Signed-off-by: Peter Hutterer <[email protected]>
Signed-off-by: Ping Cheng <[email protected]>
These haven't been needed in decades. Where a string may be empty use
quotes, otherwise let's switch string comparisons to just that. And
where we check for empty/nonempty use -z/-n.

Ported from xf86-input-wacom
Signed-off-by: Peter Hutterer <[email protected]>
Signed-off-by: Ping Cheng <[email protected]>
@Pinglinux Pinglinux merged commit d5c02aa into linuxwacom:master Mar 28, 2024
12 checks passed
@Pinglinux Pinglinux deleted the sync_release_script_with_xf86 branch March 28, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant