Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dynu code and .ini file #483

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

panosangel
Copy link

@panosangel panosangel commented May 23, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Running SWAG for the first time I got errors while setting it up to work with Dynu DNS challenge. The code for DNSPLUGIN flag was wrongly named and the .ini config file had the wrong name.

Benefits of this PR and context:

If it's not fixed, every single Dynu DNS user will have to make the same adjustments.

How Has This Been Tested?

I kept making adjustments to docker-compose.yml and the filesystem until there were no errors shown.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@aptalca
Copy link
Member

aptalca commented May 23, 2024

dynu is a different plugin and it's abandoned

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.10.0-pkg-b255070a-dev-05b586d6df5df4fb3d648db62de9273bd3329190-pr-483/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.10.0-pkg-b255070a-dev-05b586d6df5df4fb3d648db62de9273bd3329190-pr-483/shellcheck-result.xml

Tag Passed
amd64-2.10.0-pkg-b255070a-dev-05b586d6df5df4fb3d648db62de9273bd3329190-pr-483
arm64v8-2.10.0-pkg-b255070a-dev-05b586d6df5df4fb3d648db62de9273bd3329190-pr-483

@panosangel
Copy link
Author

According to docker logs DNSPLUGIN=dynudns is not a recognized value and dynu is suggested. Could it be a validation issue?

swag  | [migrations] started
swag  | [migrations] 01-nginx-site-confs-default: executing...
swag  | [migrations] 01-nginx-site-confs-default: succeeded
swag  | [migrations] done
swag  | ───────────────────────────────────────
swag  | 
swag  |       ██╗     ███████╗██╗ ██████╗
swag  |       ██║     ██╔════╝██║██╔═══██╗
swag  |       ██║     ███████╗██║██║   ██║
swag  |       ██║     ╚════██║██║██║   ██║
swag  |       ███████╗███████║██║╚██████╔╝
swag  |       ╚══════╝╚══════╝╚═╝ ╚═════╝
swag  | 
swag  |    Brought to you by linuxserver.io
swag  | ───────────────────────────────────────
swag  | 
swag  | To support the app dev(s) visit:
swag  | Certbot: https://supporters.eff.org/donate/support-work-on-certbot
swag  | 
swag  | To support LSIO projects visit:
swag  | https://www.linuxserver.io/donate/
swag  | 
swag  | ───────────────────────────────────────
swag  | GID/UID
swag  | ───────────────────────────────────────
swag  | 
swag  | User UID:    1000
swag  | User GID:    1000
swag  | ───────────────────────────────────────
swag  | 
swag  | Setting resolver to  127.0.0.11
swag  | Setting worker_processes to 8
swag  | generating self-signed keys in /config/keys, you can replace these with your own keys if required
swag  | ....+...........+...+...+.......+..+.........+.+......+........+.+.....................+++++++++++++++++++++++++++++++++++++++*....+........+.............+..+.+..+...+....+.....+......+.+++++++++++++++++++++++++++++++++++++++*....+...++++++
swag  | ..+..+...+...+....+......+..+...+++++++++++++++++++++++++++++++++++++++*......+.......+.....+................+.....+.+......+...+++++++++++++++++++++++++++++++++++++++*.+..+...+......+.+...+...............+.....+......+...............................+..................+.....+.+......+.....+..........+...+............+...+.....+......+...++++++
swag  | -----
swag  | Variables set:
swag  | PUID=1000
swag  | PGID=1000
swag  | TZ=Europe/Athens
swag  | URL=domain.com
swag  | SUBDOMAINS=wildcard
swag  | EXTRA_DOMAINS=
swag  | ONLY_SUBDOMAINS=false
swag  | VALIDATION=dns
swag  | CERTPROVIDER=
swag  | DNSPLUGIN=dynudns
swag  | [email protected]
swag  | STAGING=true
swag  | 
swag  | Please set the DNSPLUGIN variable to one of the following:
swag  | acmedns
swag  | aliyun
swag  | azure
swag  | bunny
swag  | cloudflare
swag  | cpanel
swag  | desec
swag  | digitalocean
swag  | directadmin
swag  | dnsimple
swag  | dnsmadeeasy
swag  | dnspod
swag  | do
swag  | domeneshop
swag  | dreamhost
swag  | duckdns
swag  | dynu
swag  | freedns
swag  | gandi
swag  | gehirn
swag  | glesys
swag  | godaddy
swag  | google
swag  | google-domains
swag  | he
swag  | hetzner
swag  | infomaniak
swag  | inwx
swag  | ionos
swag  | linode
swag  | loopia
swag  | luadns
swag  | namecheap
swag  | netcup
swag  | njalla
swag  | nsone
swag  | ovh
swag  | porkbun
swag  | rfc2136
swag  | route53
swag  | sakuracloud
swag  | standalone
swag  | transip
swag  | vultr

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.11.0-pkg-c57ee935-dev-b81abc31dc9b1d3030cd67185a379639b99d65dc-pr-483/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.11.0-pkg-c57ee935-dev-b81abc31dc9b1d3030cd67185a379639b99d65dc-pr-483/shellcheck-result.xml

Tag Passed
amd64-2.11.0-pkg-c57ee935-dev-b81abc31dc9b1d3030cd67185a379639b99d65dc-pr-483
arm64v8-2.11.0-pkg-c57ee935-dev-b81abc31dc9b1d3030cd67185a379639b99d65dc-pr-483

@lucas-cornette
Copy link

I'm also using dynudns and can confirm these changes have to be made to be able to use the dynu plugin.
I have renamed the ./config/dns-conf/dynu-credentials.ini file to dynu.ini and changed the DNSPLUGIN variable in my dockerfile from dynudns to dynu. After these changes, certbot is successfully generating certs for my domain.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.11.0-pkg-b36b718b-dev-35aeb158a0afb43b50c2347138bdcaf9017659bd-pr-483/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.11.0-pkg-b36b718b-dev-35aeb158a0afb43b50c2347138bdcaf9017659bd-pr-483/shellcheck-result.xml

Tag Passed
amd64-2.11.0-pkg-b36b718b-dev-35aeb158a0afb43b50c2347138bdcaf9017659bd-pr-483
arm64v8-2.11.0-pkg-b36b718b-dev-35aeb158a0afb43b50c2347138bdcaf9017659bd-pr-483

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants