-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] directadmin plugin: ValueError: too many values to unpack #474
Comments
The release isn't listed (or has been removed) on the Github repo: https://github.com/cybercinch/certbot-dns-directadmin/releases When attached to the container, I rolled back to version
🎉🎉🎉 |
Version |
Either the maintainer messed up the requirements or pip is having another issue:
|
So, 1.0.4 doesn't exist... https://github.com/cybercinch/certbot-dns-directadmin/releases |
Oh, he's using that stupid semantic-release bot that generates a new release for literally everything cybercinch/certbot-dns-directadmin@v1.0.8...v1.0.9 |
1.0.6 requires an old version of acme and therefore certbot
Current acme and certbot versions are 2.10.0 |
Yes indeed
|
After seeing all that, I'm tempted to remove the plugin altogether. Don't want to risk it breaking other stuff. |
Even in the latest release the requirement is still 1.8.0-2.0 https://github.com/cybercinch/certbot-dns-directadmin/blob/v1.0.9/pyproject.toml#L10C1-L10C19 |
Would a downgrade to What would be required to get that plugin in a better state? When I check it out in a codespace and change the versions to:
The tests pass (haven't checked anything else) |
1.0.3 seems to be from before they switched to Poetry, where the requirement was just >=1.8.0 https://github.com/cybercinch/certbot-dns-directadmin/blob/1.0.3/setup.py#L35-L37 |
I've migrated my DNS settings to Cloudflare, so I no longer rely on the DirectAdmin plugin |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is locked due to inactivity |
Is there an existing issue for this?
Current Behavior
Since the 1st of April auto-renewal is failing for me (I just noticed today as I got an email from letsencrypt about my cert expiring within a week.
log/letsencrypt/letsencrypt.log.4.gz
log/letsencrypt/letsencrypt.log.3.gz
Manually attempt when attached to the container
directadmin.ini
is like https://github.com/linuxserver/docker-swag/blob/master/root/defaults/dns-conf/directadmin.ini2.9.0-ls292
before 1st of AprilExpected Behavior
No response
Steps To Reproduce
I'm not sure, it started to happen from the 1st of April, see letsencrypt logs
Environment
CPU architecture
x86-64
Docker creation
Container logs
The text was updated successfully, but these errors were encountered: