nemo-file.c: "Always" show preview now literally means "always" #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvfs reports that we should never show thumbnails for files on mtp devices such as phones. Allow users to override this when they select "always". If it gets too slow, the file size filter can still be used to further limit for which files previews are generated. Add a new "Recommended Only" setting that uses the underlying gvfs recommendation. Based on https://gitlab.xfce.org/xfce/thunar/-/merge_requests/348 resolves linuxmint#3291
|
One known issue: the added preview option for showing previews only if recommended by gvfs shifts existing saved preview options (due to the entry added in the middle of the enum). I'm not familiar enough with gtk and how it saves/loads settings to know how to fix this. Adding the entry at the end feels out of place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gvfs reports that we should never show thumbnails for files on mtp devices such as phones. Allow users to override this when they select "always". If it gets too slow, the file size filter can still be used to further limit for which files previews are generated.
Add a new "Recommended Only" setting that uses the underlying gvfs recommendation.
Based on https://gitlab.xfce.org/xfce/thunar/-/merge_requests/348
resolves #3291