Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks menu: 'remove' and 'rename' are ambiguous #3433

Open
LinuxOnTheDesktop opened this issue Jul 10, 2024 · 4 comments
Open

Bookmarks menu: 'remove' and 'rename' are ambiguous #3433

LinuxOnTheDesktop opened this issue Jul 10, 2024 · 4 comments

Comments

@LinuxOnTheDesktop
Copy link

Distribution

Mint 21.3

Package version

6.0.2

Frequency

Always

Bug description

The bookmark context menu has 'remove' and 'rename'. Those labels make the user wonder: remove or rename the bookmark, or the bookmarked items themselves. Given, especially, that we have, in addition to bookmarks, 'My computer' and 'favourites', I think it important to reduce opportunities for confusion.

Steps to reproduce

Get up Nemo's bookmark context-menu.

Expected behavior

'Remove' -> 'Remove bookmark'.
'Rename' -> 'Rename bookmark'.

Additional information

No response

@Jeremy7701
Copy link
Contributor

Why would anyone go to the bookmarks to rename/remove the target of a bookmark?
The clue is in the name - if I remove a bookmark from a book, it doesn't remove any pages!
Rename even allows you enter the new name of the bookmark - in the bookmark menu.

@LinuxOnTheDesktop
Copy link
Author

@Jeremy7701

That is all true, except that, in short, in a GUI it is easier than with an actual book to forget the type of thing with which one is dealing with. Hopefully this screenshot illustrates:

image

Is 'Documents' - which one might be set to remove - a bookmark? Actually, it is a 'My Computer item' (and, thus I don't actually know whether it is a bookmark, or something like a bookmark).

@Jeremy7701
Copy link
Contributor

If you delete your Documents folder (or rename it or move it etc) the nemo bookmark will be highlighted (because its invalid) then next time you start nemo and you can delete or fix the bookmark.
Example:-
Screenshot from 2024-07-11 20-25-16

If you "accidentally" delete the bookmark (but not your data!) its easily recreated.

@LinuxOnTheDesktop
Copy link
Author

@Jeremy7701

Seemingly there's been some miscommunication here. My most recent point was as follows. The user wonders about the difference between the following two types of item listed in Nemo's right-hand pane: (1) those filed under 'my computer'; (2) those filed under bookmarks.

I made the foregoing point partly for its own sake - can that difference be clarified somehow/somewhere? - and in support of the following idea. It would indeed be a good idea to make more explicit, within the bookmark content menu, just what the actions in that menu will do. What is needed on that latter front is to change 'Remove' to 'Remove bookmark' and to change 'Rename' to 'Rename bookmark'. I can create a pull-request to that latter effect, but only if you are good enough to direct me towards the relevant bit of code. Thanks. Please remember that one of Mint's main goals is to be user-friendly.

aadityathapa added a commit to aadityathapa/nemo that referenced this issue Aug 21, 2024
Fixed Issue,
 Bookmarks menu: 'remove' and 'rename' are ambiguous linuxmint#3433 

This seems like a valid point and a easy fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants