Fix notification text #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously got html-escaped text and our added link/image HTML all in the notification, which didn't look very nice.
mtwebster
reviewed
Mar 15, 2024
rcalixte
reviewed
Mar 15, 2024
|
We can't allow HTML tags to get into the notification. What we can do though is remove them altogether. i.e. we escape them for webkit, and remove them for notify. |
Why exactly? |
@clefebvre Ah, Notify supports some HTML in the notifications but isn't happy with escaping...is there an option to forbid Notify to parse text as HTML? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously got html-escaped text and our added link/image HTML all in the notification, which didn't look very nice.
Will fix: #7