Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit white backgrounds for QR codes #15

Open
knghtbrd opened this issue Aug 13, 2020 · 2 comments
Open

Explicit white backgrounds for QR codes #15

knghtbrd opened this issue Aug 13, 2020 · 2 comments

Comments

@knghtbrd
Copy link

Hi, just thought you might want to make the white backgrounds on your QR codes explicitly white:

image

This nice dark Github theme is an override CSS, true, ("GithubDarkTheme();" specifically) but it's very well behaved and if MS ever implements one, they're likely to do it similarly. This is just one of those cases where you don't really want an alpha background.

@tutacat
Copy link

tutacat commented Mar 21, 2021

or have it as an jpg/opaque png

😂 ms wouldn't enable force dark mode by default, mostly because of compatibility like that

Also, force dark mode (chromium) replaces even white explicit background with opposite color

@knghtbrd
Copy link
Author

Definitely reason to test with multiple browsers. Chrome's "force dark mode", if it now uses the stuff Brave does (which was probably a Chrome experimental feature) is sort of an in-browser darkreader extension. That's guaranteed to break things sooner or later just because it's indiscriminate. Mostly yes, the background should not be transparent. Or at least there should be a white background under it that maybe fuzzes at the edges to pure alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants