Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when window flashes #336

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

justforlxz
Copy link
Member

Actively move the activation state of the window that is about to be closed

Log:

@justforlxz justforlxz requested a review from Groveer June 26, 2024 08:31
@justforlxz justforlxz force-pushed the master branch 2 times, most recently from 69064a1 to 618f14a Compare June 26, 2024 10:04
@Groveer
Copy link
Contributor

Groveer commented Jun 26, 2024

/help

1 similar comment
@Groveer
Copy link
Contributor

Groveer commented Jun 26, 2024

/help

Actively move the activation state of the window that is about to be
closed

Log:
change to function call

Log:
auto select surface will find a cannot be activate surface.

Log:
dde-desktop and dde-launchapd not support layershell.

Log:
set focus to activate window

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ForeignToplevelV1::add函数中,对surface->safeConnect的调用可能导致潜在的信号连接问题,因为safeConnect可能会在连接之前删除对象。建议使用connect函数来确保连接的安全性。
  • ForeignToplevelV1::Attached函数的命名可能会引起混淆,因为它实际上是在创建一个ForeignToplevelAttached对象,而不是返回一个已经存在的对象。建议更改函数名为CreateAttached以更准确地描述其功能。
  • PersonalizationV1::Attached函数中,直接使用qobject_cast可能会导致运行时错误,如果target不是有效的WXdgSurfaceWXWaylandSurface对象。建议使用更安全的类型转换方法。
  • Helper::selectSurfaceToActivate函数中,对surface的检查应该在访问其属性之前进行,以避免潜在的未定义行为。
  • Helper::setMovingItem函数中,moveReiszeState.movingItem的访问应该在确保其有效之后进行,以避免潜在的未定义行为。
  • Helper::setActivateSurface函数中,invalidCheck的连接应该在m_activateSurface被设置为新值之后进行,以避免潜在的信号连接问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Groveer Groveer merged commit 21d47d0 into linuxdeepin:master Jun 27, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants