feat: Implement treeland_virtual_manager_v1 function #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Dami-star The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Dami-star
force-pushed
the
virtual-output
branch
19 times, most recently
from
e460e66
to
05eeb34
Compare
justforlxz
reviewed
Jun 27, 2024
| Q_OBJECT | ||
| QML_ANONYMOUS | ||
|
|
||
| public: |
There was a problem hiding this comment.
在这里增加一个属性，可以获取和当前WOutput相关的viewport，以及changed
| public: | ||
| explicit VirtualOutputV1(QObject *parent = nullptr); | ||
|
|
||
| // static TreelandVirtualOutput *qmlAttachedProperties(QObject *target); |
There was a problem hiding this comment.
Suggested change
| // static TreelandVirtualOutput *qmlAttachedProperties(QObject *target); | |
| VirtualOutputManagerAttached *Attach(WOutput *output); |
Dami-star
force-pushed
the
virtual-output
branch
3 times, most recently
from
8a9f082
to
87af987
Compare
Implementing Virtual Output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Virtual Output