Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 如果窗口打开时即为最大化状态,则最大化图标显示错误 #601

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Whale107
Copy link
Contributor

窗口打开时没有windowstatechanged事件,不会去设置窗口状态,在showEvent中处理一下

Log:
Bug: https://pms.uniontech.com/bug-view-262201.html Influence: mainwindow最大化

窗口打开时没有windowstatechanged事件,不会去设置窗口状态,在showEvent中处理一下

Log:
Bug: https://pms.uniontech.com/bug-view-262201.html
Influence: mainwindow最大化
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 方法名 handleParentWindowIdChange 更改为 handleParentWindowStateChange 可能意味着方法的功能已经发生了变化,需要确认新方法是否正确实现了相同的功能。
  • 检查是否有对应的单元测试来验证此更改后功能的变化。

是否建议立即修改:

  • 是,需要确保方法名更改后功能正确,并且如果有相关的单元测试,应该确保它们也得到了更新。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 28, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#601
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 28, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107 Whale107 merged commit 553522e into linuxdeepin:master Aug 29, 2024
20 of 21 checks passed
FeiWang1119 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Sep 25, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants