fix DArrowRectangle background color abnormality #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zccrs
reviewed
Aug 18, 2023
| @@ -27,6 +27,10 @@ static QWindow *ensureWindowHandle(QWidget *widget) | |||
| handle = window->windowHandle(); | |||
| window->setAttribute(Qt::WA_NativeWindow, false); | |||
|
|
|||
| // FIX developer-center#5187 updateIsTranslucent | |||
| if (window->testAttribute(Qt::WA_TranslucentBackground)) | |||
| window->setAttribute(Qt::WA_OpaquePaintEvent); | |||
There was a problem hiding this comment.
这不会有副作用吗，有 Qt::WA_TranslucentBackground 时不应该是需要背景透明
There was a problem hiding this comment.
主要是想设置透明通道
setAttribute(Qt::WA_OpaquePaintEvent) ==> updateIsOpaque() ==> setOpaque ==> updateIsTranslucent
不过调用的过程确实有点多， 可能会有副作用。起作用的是 window->setFormat(format);
void QWidgetPrivate::updateIsTranslucent()
{
Q_Q(QWidget);
if (QWindow *window = q->windowHandle()) {
QSurfaceFormat format = window->format();
const int oldAlpha = format.alphaBufferSize();
const int newAlpha = q->testAttribute(Qt::WA_TranslucentBackground)? 8 : 0;
if (oldAlpha != newAlpha) {
format.setAlphaBufferSize(newAlpha);
window->setFormat(format);
}
}
}There was a problem hiding this comment.
Qt6 貌似修复了，不过还没找到改的地方在哪里 🥲
|
Doc Check bot |
|
暂时关闭。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX linuxdeepin/developer-center#5187
Bug: https://pms.uniontech.com/bug-view-211649.html