Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#602

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#602
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DMainWindowPrivate::DMainWindowPrivate函数中,新增的代码块可能会导致enableNoTitlebar的逻辑不正确,因为qEnvironmentVariable的调用可能会影响全局状态,这可能不是预期行为。
  • DTitlebarPrivate::init函数中,新增的代码块可能会导致enableNoTitlebar的逻辑不正确,因为qEnvironmentVariable的调用可能会影响全局状态,这可能不是预期行为。
  • DTitlebarPrivate::updateButtonsState函数中,新增的代码块可能会导致isFullscreen的逻辑不正确,因为qEnvironmentVariable的调用可能会影响全局状态,这可能不是预期行为。
  • DTitlebar::eventFilter函数中,d->handleParentWindowStateChange();的调用可能不正确,因为handleParentWindowStateChange函数没有在代码更改中显示,需要确认其存在且功能正确。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant