Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #60

Merged
merged 1 commit into from
Jul 3, 2024
Merged

sync: from linuxdeepin/dtkwidget #60

merged 1 commit into from
Jul 3, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#584

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2024

TAG Bot

New tag: 6.0.17
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #59

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#584
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DAbstractDialogPrivate::init函数中,新增代码可能会导致handle对象在未启用模糊窗口的情况下被错误地设置为启用。
  • DDialogPrivate::init函数中,设置按钮布局的间距可能不适用于所有情况,应确保间距设置的合理性。
  • DMessagemanager中,对content的检查应该在循环外进行,以避免在每次迭代时都调用findChild
  • sendMessage_helper函数中,对content的检查应该使用QObject::findChildren的过滤器参数,而不是在循环内遍历子对象。

是否建议立即修改:

@mhduiy
Copy link
Contributor

mhduiy commented Jul 3, 2024

/rebase

@mhduiy mhduiy merged commit ea9b690 into master Jul 3, 2024
11 of 14 checks passed
@mhduiy mhduiy deleted the sync-pr-584-nosync branch July 3, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants