Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkwidget #52

Merged
merged 1 commit into from
May 13, 2024
Merged

sync: from linuxdeepin/dtkwidget #52

merged 1 commit into from
May 13, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#572

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#572
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • QWidget *follower{nullptr};QWidget *target{nullptr};更改为QPointer<QWidget> follower;QPointer<QWidget> target;提高了代码的一致性和可维护性。

是否建议立即修改:

  • 否,因为这个提交中的更改已经提高了代码质量。但是,如果有其他地方也使用了原始的指针类型,建议统一修改为QPointer以保持一致性。同时,应该检查是否有必要使用QPointer而不是QWidget *,以适应不同的使用场景。

@kegechen kegechen merged commit 7541820 into master May 13, 2024
7 of 12 checks passed
@kegechen kegechen deleted the sync-pr-572-nosync branch May 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants