fix: column editing and insert #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete command stores temporary reference variable, which will be empty when changing cursor. Change storage variable type to store data persistently. Log: Fix crash when undoing column edit Bug: https://pms.uniontech.com/bug-view-273663.html Influence: column-editing
As title. update backward / forward delete; update unit test. Log: Restore column selection after undo. Bug: https://pms.uniontech.com/bug-view-273663.html Influence: column-editing
As title. Log: Fix column insert text.
deepin pr auto reviewFix the test for insert undo command |
starhcq
approved these changes
Sep 25, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rb-union, starhcq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[是否满足兼容性要求] Y |
1 similar comment
|
[是否满足兼容性要求] Y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: crash when undoing column edit
Delete command stores temporary reference variable,
which will be empty when changing cursor.
Change storage variable type to store data persistently.
Log: Fix crash when undoing column edit
Bug: https://pms.uniontech.com/bug-view-273663.html
Influence: column-editing
fix: restore column selection after undo
As title.
update backward / forward delete;
update unit test.
Log: Restore column selection after undo.
Bug: https://pms.uniontech.com/bug-view-273663.html
Influence: column-editing
fix: cursor pos wrong after column insertion.
As title.
Log: Fix column insert text.