fix: onPressedLineNumber() may cause process hangs. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
点击序号列空白处，可能导致程序阻塞，这是由于循环判断 没有检查 QTextBlock 是否有效。 1. 修改 onPressedLineNumber() 函数，改为使用 cursorForPosition() 接口取得块位置，而非循环比对块区域范围。 2. 补充 onPressedLineNumber() 的单元测试。 Log: 修复一次点击序号可能导致程序阻塞的问题 Bug: https://pms.uniontech.com/bug-view-215591.html Influence: LineNumber
|
/reivew @starhcq |
|
/+1 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rb-union, starhcq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rb-union
added a commit
to rb-union/deepin-editor
that referenced
this pull request
Aug 31, 2023
Update version to 6.0.12 PR: * linuxdeepin#259 Log: Update version to 6.0.12
starhcq
pushed a commit
that referenced
this pull request
Aug 31, 2023
Update version to 6.0.12 PR: * #259 Log: Update version to 6.0.12
rb-union
added a commit
to rb-union/deepin-editor
that referenced
this pull request
Aug 20, 2024
Update version to 6.0.12 PR: * linuxdeepin#259 Log: Update version to 6.0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
点击序号列空白处，可能导致程序阻塞，这是由于循环判断
没有检查 QTextBlock 是否有效。
Log: 修复一次点击序号可能导致程序阻塞的问题
Bug: https://pms.uniontech.com/bug-view-215591.html
Influence: LineNumber