Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [security] add polkit with setSingleInstance #363

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jeffshuai
Copy link
Contributor

move polkit after SingleInstance

Log: add polkit support setSingleInstance

Task:https://pms.uniontech.com/task-view-364005.html

  move polkit after SingleInstance

Log:  add polkit support setSingleInstance

Task:https://pms.uniontech.com/task-view-364005.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了对Dbus驱动接口的初始化,可能影响应用程序的功能
  • 添加了对单实例化的检查,但未提供错误处理或日志记录
  • 移除了对用户授权的检查,可能会导致未授权的用户访问应用程序

是否建议立即修改:

@myk1343
Copy link
Contributor

myk1343 commented Oct 9, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@jeffshuai jeffshuai closed this Oct 10, 2024
@jeffshuai jeffshuai reopened this Oct 10, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeffshuai, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffshuai
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 10, 2024

This pr cannot be merged! (status: unstable)

@max-lvs max-lvs merged commit dd0d7ca into linuxdeepin:master Oct 10, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants