Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect Provides/Or dependencies error. #228

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

rb-union
Copy link
Contributor

修复同时存在虚包依赖/或依赖时检测错误,
旧版流程基于包不会重复给出ok结果,
引入考虑虚包场景,检测包和实际包名不一致,
导致依赖包未能正常安装.

含虚包依赖/或依赖检测过程:

  1. 检测前清理缓存状态;
  2. 顺序遍历(后续依赖可能已安装)或依赖;
  3. 依赖中存在非ok依赖,缓存包依赖状态;
  4. 检测到重复包,返回缓存状态,而不是直接返回ok.

Issue: https://pms.uniontech.com/bug-view-212307.html
Influence: ProvidesDepends OrDepends

@rb-union
Copy link
Contributor Author

/review @starhcq

@github-actions github-actions bot requested a review from starhcq October 16, 2023 06:27
@rb-union
Copy link
Contributor Author

/check OBS

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 23, 2023

Deepin ChatOps Bot
Deepin redeliveried failed, need update or recreate pull request!!!

修复同时存在虚包依赖/或依赖时检测错误,
旧版流程基于包不会重复给出ok结果,
引入考虑虚包场景,检测包和实际包名不一致,
导致依赖包未能正常安装.

含虚包依赖/或依赖检测过程:
1. 检测前清理缓存状态;
2. 顺序遍历(后续依赖可能已安装)或依赖;
3. 依赖中存在非ok依赖,缓存包依赖状态;
4. 检测到重复包,返回缓存状态,而不是直接返回ok.

Issue: https://pms.uniontech.com/bug-view-212307.html
Influence: ProvidesDepends OrDepends
Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit ec0888f into linuxdeepin:release/eagle Oct 31, 2023
13 checks passed
@rb-union rb-union deleted the fix_212307 branch October 31, 2023 07:52
rb-union added a commit to rb-union/deepin-deb-installer that referenced this pull request Nov 3, 2023
Bump version to 6.0.17
PR:
* linuxdeepin#228

Log: Bump version to 6.0.17
starhcq pushed a commit that referenced this pull request Nov 3, 2023
Bump version to 6.0.17
PR:
* #228

Log: Bump version to 6.0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants