Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复追加文件为软连接问题 #191

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Sep 13, 2024

修复追加文件为软连接问题

Bug: https://pms.uniontech.com/bug-view-273297.html
Log: 修复追加文件为软连接问题

修复追加文件为软连接问题

Bug: https://pms.uniontech.com/bug-view-273297.html
Log: 修复追加文件为软连接问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增代码中,isLink变量被赋值为true,但在后续代码中没有看到对其值的修改,可能导致isLink始终为true,无法正确判断文件是否为链接。
  • 在处理7z程序的参数时,直接修改了arguments的值,但没有对arguments的类型进行安全检查,可能会导致运行时错误。
  • 在检查-snl参数是否存在的逻辑中,使用了arguments.at(i)来获取参数值,但没有考虑到arguments可能为空或索引越界的情况。
  • 新增代码中没有对m_cliProps->property("addProgram").toString()的返回类型进行断言,可能会导致在某些情况下出现类型转换异常。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Sep 13, 2024

/merge

@deepin-bot deepin-bot bot merged commit ba71034 into linuxdeepin:release/eagle Sep 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants