Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build failures for new dtkgui #150

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

felixonmars
Copy link
Member

Fixes the following build failures:

/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp: In member function ‘virtual QVariant DataModel::data(const QModelIndex&, int) const’:
/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp:105:17: error: ‘DGuiApplicationHelper’ has not been declared
  105 |             if (DGuiApplicationHelper::instance()->sizeMode() == DGuiApplicationHelper::NormalMode) {
      |                 ^~~~~~~~~~~~~~~~~~~~~
/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp:105:66: error: ‘DGuiApplicationHelper’ has not been declared
  105 |             if (DGuiApplicationHelper::instance()->sizeMode() == DGuiApplicationHelper::NormalMode) {
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该写到 cpp 里吧,头文件里并没有用到它

Fixes the following build failures:
```
/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp: In member function ‘virtual QVariant DataModel::data(const QModelIndex&, int) const’:
/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp:105:17: error: ‘DGuiApplicationHelper’ has not been declared
  105 |             if (DGuiApplicationHelper::instance()->sizeMode() == DGuiApplicationHelper::NormalMode) {
      |                 ^~~~~~~~~~~~~~~~~~~~~
/home/felix/projects/deepin/deepin-compressor/src/source/tree/datamodel.cpp:105:66: error: ‘DGuiApplicationHelper’ has not been declared
  105 |             if (DGuiApplicationHelper::instance()->sizeMode() == DGuiApplicationHelper::NormalMode) {
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~
```
@felixonmars
Copy link
Member Author

应该写到 cpp 里吧,头文件里并没有用到它

已修正

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, felixonmars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 9130b9d into linuxdeepin:release/eagle Oct 19, 2023
13 checks passed
@felixonmars felixonmars deleted the fix-missing-header branch October 19, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants