fix(build): Remove unnecessary dependencies #366
Conversation
| @@ -1,4 +1,5 @@ | |||
| find_package(QT NAMES Qt6 Qt5 COMPONENTS Widgets WebEngineWidgets REQUIRED) | |||
| # install qtwebengine5-dev / qt6-webengine-dev manually | |||
| find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Widgets WebEngineWidgets REQUIRED) | |||
There was a problem hiding this comment.
既然移除了dev的依赖，cmake里面是不是也要移除掉find_package。
There was a problem hiding this comment.
这个模块 debug 才编译，不 find_package 的话 debug 编译都失败了
There was a problem hiding this comment.
判断是否找到，没找到加一个message(ERROR)吧，写在注释里面比较难看到。
There was a problem hiding this comment.
没找到 cmake 就直接编译失败了 🤣
There was a problem hiding this comment.
如果有人执行了sudo apt build-dep . 还编译失败，那他就会很疑惑了，失败的时候把原因打印出来。
|
TAG Bot New tag: 6.0.18 |
qtwebengine5-dev build dependcies unnecessary
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FeiWang1119, kegechen, Zeno-sole The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qtwebengine5-dev build dependcies unnecessary