fix: login stuck for passwordless users in nopasswdlogin group #331
Conversation
| if (!user_ptr->isPasswordValid()) { | ||
| qWarning() << userPath; | ||
| emit m_model->authFailedTipsMessage(tr("Wrong account")); | ||
| m_model->setAuthType(AT_None); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Moving these all to the end of the function might lead to creating authentication even when the user is not in the nopasswdlogin group and his or her password is not set. I think you should judge if a user is in the nopasswdlogin group right here.
There was a problem hiding this comment.
Hi, how do you think about my comment here?
|
By the way, please rebase your branch and pass all the checks. |
|
TAG Bot New tag: 6.0.15 |
|
TAG Bot New tag: 6.0.16 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openarun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.0.17 |
Password less users in the group nopasswdlogin was stuck in the login screen. Log: fix login stuck for passwordless users in nopasswdlogin group
|
According to our current policy, we don't allow passwordless users even if we provide nopasswdlogin. All users must set a password. |
Password less users in the group nopasswdlogin was stuck in the login screen.
Log: fix login stuck for passwordless users in nopasswdlogin group