fix: failed to fallback default icon #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's maybe a bug for deepin-app-store-tool. App's icon is installed in /opt, the tool will create a link for it's icons, but the action is async, icon-theme.cache is not ready when launchpad is read. and we only ensure display an X icon when icon is invalid. Issue: linuxdeepin/developer-center#6860
18202781743
force-pushed
the
missing-icon
branch
from
d1bfa1a
to
c600702
Compare
BLumia
approved these changes
Jan 13, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's maybe a bug for deepin-app-store-tool. App's icon is installed
in /opt, the tool will create a link for it's icons, but the action
is async, icon-theme.cache is not ready when launchpad is read.
and we only ensure display an X icon when icon is invalid.
Issue: linuxdeepin/developer-center#6860