Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the fullscreen launcher indicator is not aligned #407

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

xionglinlin
Copy link
Contributor

Fix the alignment of the launcher indicator

Issue: linuxdeepin/developer-center#9993

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了topPadding: 10可能会影响布局的完整性,需要确认是否有其他代码来处理顶部空白。
  • anchors属性中添加了verticalCenter,这可能会改变子组件的位置,需要检查这一改动是否符合设计要求。
  • 调整了Rectanglewidthheight属性,这可能会影响布局和用户界面外观。

是否建议立即修改:

  • 是,需要确保移除topPadding: 10不会导致布局问题,并且添加verticalCenter是必要的。同时,应该验证Rectangle尺寸的改动是否符合预期效果。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit d1e03a9 into linuxdeepin:master Aug 23, 2024
7 of 10 checks passed
@xionglinlin xionglinlin deleted the fix/9993 branch September 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants