Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify the fullscreen launcher window opening and closing animation #401

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

xionglinlin
Copy link
Contributor

Change window startup effect to EffectOut

Issue: linuxdeepin/developer-center#10322

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Aug 15, 2024

TAG Bot

New tag: 0.8.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #400

@xionglinlin
Copy link
Contributor Author

/retest

@xionglinlin
Copy link
Contributor Author

/retest

1 similar comment
@xionglinlin
Copy link
Contributor Author

/retest

@xionglinlin xionglinlin reopened this Aug 21, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在debian/control文件中,对libdtk6gui-dev和libdtk6declarative-dev的依赖版本进行了限制,增加了版本号要求。
  • 在qml/Main.qml文件中,添加了一个新的属性DWindow.windowStartUpEffect,并设置了其值为PlatformHandle.EffectOut

是否建议立即修改:

  • 否,这次提交的修改看起来是对项目依赖和QML属性的新增,没有明显的错误或者需要立即修复的问题。但是,建议进行以下几点检查和改进:
    • 确认添加的依赖版本限制是否与项目兼容,避免引入不必要的版本冲突。
    • 验证DWindow.windowStartUpEffect属性的添加是否与现有的QML组件和逻辑兼容,避免引入新的bug。
    • 如果PlatformHandle.EffectOut是一个自定义效果,请确保它已经被正确实现,并且与现有的效果处理机制兼容。
    • 添加必要的单元测试来验证这些更改不会引入新的问题,特别是在依赖版本限制和QML属性的变更上。

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 21, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 7c4b96a into linuxdeepin:master Aug 21, 2024
12 of 15 checks passed
@xionglinlin xionglinlin deleted the fix/10322 branch August 21, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants