-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: correct app id used by DConfig #383
Conversation
Skipping CI for Draft Pull Request. |
和 @tsic404 讨论了下,之前因为存在跨组件(launchpad 到 dock)拖拽和呈现应用列表的需求,所以这块原本是有独立出来让 launchpad 和 dock 共用的计划的。如果按这个方案的话,这个组件的合适的组件名应该是 目前离发版比较近,肯定不会有较大改动,测试应该也期望尽可能兼容之前的配置,直接进行调整并明确告知不兼容早期版本的 launchpad 虽然可行,但后续组件拆分后可能还是要做一次这件事(并且那时候应该还需要主动做配置迁移支持)。所以目前方案有两个:
考虑下实际选什么方案,或者有没有更合适的方案? |
当下初步结论:仍需调整,且需要提供配置迁移功能。 应用 id 需和可执行直接对应,将调整为 迁移功能具体方案待定,至少 dde-shell 自身计划提供一个进行于组件初始化前的配置迁移支持。 |
6fbb1ba
to
3f2b332
Compare
TAG Bot New tag: 0.8.3 |
纠正应用组件 ID 名称。 Log: Influnce: 不再兼容之前的 dde-launchpad 配置文件
deepin pr auto review关键摘要:
是否建议立即修改:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, tsic404 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
纠正应用组件 ID 名称。
Log:
Influnce: 不再兼容之前的 dde-launchpad 配置文件
关联:
若未注明,均需先确认无问题再合入。