Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: correct app id used by DConfig #383

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Aug 6, 2024

纠正应用组件 ID 名称。

Log:
Influnce: 不再兼容之前的 dde-launchpad 配置文件


关联:

若未注明,均需先确认无问题再合入。

@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@BLumia BLumia marked this pull request as ready for review August 6, 2024 05:41
@BLumia
Copy link
Member Author

BLumia commented Aug 6, 2024

@zccrs

@tsic404 讨论了下,之前因为存在跨组件(launchpad 到 dock)拖拽和呈现应用列表的需求,所以这块原本是有独立出来让 launchpad 和 dock 共用的计划的。如果按这个方案的话,这个组件的合适的组件名应该是 org.deepin.ds.applications 而不是 org.deepin.{dde,ds}.launchpad,其中的一些配置会被拆分出去。

目前离发版比较近,肯定不会有较大改动,测试应该也期望尽可能兼容之前的配置,直接进行调整并明确告知不兼容早期版本的 launchpad 虽然可行,但后续组件拆分后可能还是要做一次这件事(并且那时候应该还需要主动做配置迁移支持)。所以目前方案有两个:

  1. 暂时保持不变,不做修改(AppStream 元信息的 ID 倒是可以改,那个不影响到任何配置的兼容性)
  2. 先调整 ID 到 org.deepin.ds.launchpad,明确告知正式版 launchpad 不兼容所有测试版 launchpad 的历史配置

考虑下实际选什么方案,或者有没有更合适的方案?

@BLumia
Copy link
Member Author

BLumia commented Aug 6, 2024

考虑下实际选什么方案,或者有没有更合适的方案?

当下初步结论:仍需调整,且需要提供配置迁移功能。

应用 id 需和可执行直接对应,将调整为 org.deepin.dde.shell。另因 dde-shell 的 DConfig 所用的应用 id 也有问题,所以 dde-shell 也需要做出对应调整并提供迁移功能。

迁移功能具体方案待定,至少 dde-shell 自身计划提供一个进行于组件初始化前的配置迁移支持。

@BLumia BLumia force-pushed the dconfig-appid branch 4 times, most recently from 6fbb1ba to 3f2b332 Compare August 7, 2024 02:33
@deepin-bot
Copy link

deepin-bot bot commented Aug 7, 2024

TAG Bot

New tag: 0.8.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #384

纠正应用组件 ID 名称。

Log:
Influnce: 不再兼容之前的 dde-launchpad 配置文件
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中的文件路径和配置文件名已更改,确保新路径和文件名与实际项目结构相匹配。
  • 检查是否有其他代码依赖于旧的配置文件路径和名称,以避免潜在的兼容性问题。
  • 确认新的配置文件格式是否与预期的格式兼容,并验证其功能是否符合预期。

是否建议立即修改:

  • 是,需要确保配置文件路径和名称的更改不会影响现有的功能和兼容性。同时,确保新的配置文件格式与项目需求相匹配。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit a20a2c5 into linuxdeepin:master Aug 8, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants