Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fullscreen frame follows the dock #381

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

xionglinlin
Copy link
Contributor

Set the screen of the dock to the screen of the fullscreen frame

Issue: linuxdeepin/developer-center#7188

Set the screen of the dock to the screen of the fullscreen frame

Issue: linuxdeepin/developer-center#7188
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ContainmentItem中新增了alias fullscreenFrame属性,但未在代码中看到对应属性的使用。
  • Main组件的id被设置为main,可能与现有的main组件或变量冲突,建议更改以避免潜在的命名冲突。

是否建议立即修改:

@xionglinlin
Copy link
Contributor Author

/review @BLumia

@github-actions github-actions bot requested a review from BLumia August 5, 2024 09:32
@BLumia BLumia requested review from 18202781743 and removed request for BLumia August 5, 2024 09:39
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 6, 2024

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit d7c618a into linuxdeepin:master Aug 6, 2024
9 of 10 checks passed
@zsien zsien deleted the fix/7188 branch August 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants