Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no longer hide exit fullscreen button on TreeLand #368

Merged
merged 1 commit into from
Jul 26, 2024
Merged

chore: no longer hide exit fullscreen button on TreeLand #368

merged 1 commit into from
Jul 26, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Jul 26, 2024

Log:

@BLumia BLumia requested a review from justforlxz July 26, 2024 06:14
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了对环境变量 "DDE_CURRENT_COMPOSITOR" 的检查，可能会导致在非 TreeLand 环境下显示退出全屏按钮，需要确认这是否是预期行为。

是否建议立即修改:

  • 是，如果移除这个检查不是故意的，那么应该立即修复以避免潜在的功能问题。如果这是故意的，那么应该更新相关的文档或注释来解释为什么这个条件被移除。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 8f2fd8a into linuxdeepin:master Jul 26, 2024
9 of 10 checks passed
@BLumia BLumia deleted the treeland-btn branch July 26, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justforlxz justforlxz justforlxz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BLumia @deepin-ci-robot @justforlxz