Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot open apps inside folders with keyboard #367

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ArchieMeng
Copy link
Contributor

Key events are filtered by upper droparea delegate, and need to be forwarded to inner IconItemDelegate.

Issue: linuxdeepin/developer-center#9930
Log: Cannot open apps inside folders with keyboard

Key events are filtered by upper droparea delegate, and need to be
forwarded to inner IconItemDelegate.

Issue: linuxdeepin/developer-center#9930
Log: Cannot open apps inside folders with keyboard
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Keys.forwardTo属性中使用了innerItem,但未在代码中看到innerItem的定义或修改,可能会导致引用错误。
  • displayFont属性使用了isWindowedMode变量,但未在代码中看到isWindowedMode的定义或修改,可能会导致未定义行为。
  • 新增的Keys.forwardTo属性可能需要与现有代码库的其他部分进行兼容性检查,以确保不会引入新的问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng
Copy link
Contributor Author

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jul 26, 2024

This pr cannot be merged! (status: unstable)

@ArchieMeng
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 26, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit a4deaa3 into linuxdeepin:master Jul 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants