Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): fullscreen item pre-drop arrangement animation #366

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Jul 26, 2024

鼠标释放前的位移动画。动画发生时实际已发生了model操作。

Log:

鼠标释放前的位移动画。动画发生时实际已发生了model操作。

Log:
@BLumia BLumia requested a review from tsic404 July 26, 2024 02:40
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • onEntered函数中,dndDropEnterTimer.dragId的赋值应该在folderGridViewPopup.opened的检查之后,以确保在拖动开始时不会尝试获取数据。
  • dndDropEnterTimer.dragId = drag.getDataAsString("text/x-dde-launcher-dnd-desktopId")应该在dndDropEnterTimer.restart()之前设置,以确保在拖动开始时不会尝试获取数据。
  • dndDropEnterTimer.stop()dndDropEnterTimer.dragId = ""应该在onExited函数中调用,以确保在拖动结束时正确地清理状态。
  • dndDropEnterTimer.stop()dndDropEnterTimer.dragId = ""应该在onDropped函数中调用,以确保在拖动结束时正确地清理状态。
  • dndDropEnterTimerinterval属性设置为500毫秒,但实际逻辑处理可能需要更长的延迟,以避免在拖动开始时立即触发dndDropEnterTimer.onTriggered
  • dropOnItem函数的实现没有提供,无法评估其正确性和性能。
  • onTriggered函数中的逻辑处理可能需要更详细的错误处理,以处理可能出现的潜在问题。

是否建议立即修改:

Copy link
Member

@wineee wineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(仅看看颜色

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 08b8241 into linuxdeepin:master Jul 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants