Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide app-folder icon when its folder is visible #358

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Jul 22, 2024

当应用文件夹显示时,隐藏应用文件夹图标本身。

Log:

当应用文件夹显示时,隐藏应用文件夹图标本身。

Log:
@BLumia BLumia requested a review from tsic404 July 22, 2024 12:06
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,使用了硬编码的字符串 "internal/folders/" 来替换桌面 ID,这可能会导致跨平台兼容性问题。
  • visible 属性中的条件判断逻辑可能存在逻辑错误,folderGridViewPopup.currentFolderId 应该与 Number(model.desktopId.replace("internal/folders/", "")) 进行比较。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit fc34aee into linuxdeepin:master Jul 22, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants