Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the launcher application folder title #341

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

xionglinlin
Copy link
Contributor

Modify the color and position of the launcher application folder title

Issue: linuxdeepin/developer-center#9446

Modify the color and position of the launcher application folder title

Issue: linuxdeepin/developer-center#9446
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FolderGridViewPopup.qml文件中,Layout.preferredHeight的值从5增加到15,需要确认这是否符合设计要求。
  • 新增的Palette属性titleTextColor可能需要与其他相关属性进行整合,以确保一致性和可维护性。
  • TextInput组件中,color属性从使用palette.windowText更改为contentRoot.ColorSelector.titleTextColor,需要验证这是否符合UI设计的预期。

是否建议立即修改:

  • 是,特别是如果preferredHeight的更改会影响到布局或用户界面的话。对于titleTextColor的更改,如果与设计规范不一致,也应该立即进行修正。

@xionglinlin
Copy link
Contributor Author

/review @BLumia

@github-actions github-actions bot requested a review from BLumia July 5, 2024 02:51
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 5, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 8026a3f into linuxdeepin:master Jul 5, 2024
9 of 10 checks passed
@xionglinlin xionglinlin deleted the fix/9446 branch August 5, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants