Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to 0.7.5 #337

Merged
merged 4 commits into from
Jul 2, 2024
Merged

bump version to 0.7.5 #337

merged 4 commits into from
Jul 2, 2024

Conversation

xionglinlin
Copy link
Contributor

@xionglinlin xionglinlin commented Jun 27, 2024 •
edited
Loading

xionglinlin and others added 4 commits June 27, 2024 10:46
@xionglinlin
fix: modify the background blur effect
fb23c29 
Modify the background blur effect of the full-screen application group

Issue: linuxdeepin/developer-center#9374
@xionglinlin
fix: modify the background of the menuitem
41787dc 
Modify the background of the menuitem to be the same as AlphabetCategoryPopup

Issue: linuxdeepin/developer-center#8807
@zsien @xionglinlin
fix: cannot hide the window after switching to windowed mode
6d7e942 
为了解决 https://github.com/linuxdeepin/developer-center/issues/6818，
设置了忽略切换模式后 1s 内的 activeChanged 事件。
导致切换到窗口模式后， 1s 内点击空白处，窗口无法再关闭

Issues: linuxdeepin/developer-center#8916
@xionglinlin
chore: bump version to 0.7.5
76063c3 
release 0.7.5

Log: bump version to 0.7.5
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在launchercontroller.h和launchercontroller.cpp的修改中，移除了shouldAvoidHideOrActive函数，但未提供替代逻辑或说明原因。
  • 在FolderGridViewPopup.qml中，修改了Popup的高度计算方式，增加了对奇数高度的判断，但未解释为什么需要这样做。
  • 在Main.qml中，删除了对LauncherController.shouldAvoidHideOrActive的调用，直接调用LauncherController.hideWithTimer，这可能会改变原有的行为，需要确认是否有替代逻辑。
  • 在AppListView.qml中，新增了一个background属性，但未提供背景颜色的默认值或说明其用途。

是否建议立即修改:
是

  • 需要提供对launchercontroller.h和launchercontroller.cpp中移除shouldAvoidHideOrActive函数的解释，以及替代逻辑的说明，以确保代码的完整性和可维护性。
  • 需要解释为什么需要在FolderGridViewPopup.qml中增加对奇数高度的判断，以及这种修改的合理性。
  • 需要确认Main.qml中删除对LauncherController.shouldAvoidHideOrActive的调用是否符合预期行为，并补充相应的替代逻辑或说明。
  • 需要提供AppListView.qml中新增的background属性的默认值和用途说明，以确保代码的一致性和可读性。

@github-actions GitHub Actions
Copy link

TAG Bot

TAG: 0.7.5
EXISTED: no
DISTRIBUTION: unstable

@xionglinlin
Copy link
Contributor Author

/integrate

@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Jun 27, 2024
Open
@github-actions GitHub Actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1653
PrNumber: 1653
PrBranch: auto-integration-9690131965

@zsien
Copy link
Member

zsien commented Jun 27, 2024

帮我把 #338 带进去

@xionglinlin
Copy link
Contributor Author

/review @BLumia @kegechen 测试通过

@github-actions github-actions bot requested review from BLumia and kegechen July 2, 2024 01:29
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit d25d279 into linuxdeepin:release/rc2 Jul 2, 2024
10 of 11 checks passed
@deepin-bot deepin-bot bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

@kegechen kegechen Awaiting requested review from kegechen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xionglinlin @deepin-ci-robot @zsien @BLumia @kegechen