Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify the color property of the menuitem hover #333

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

xionglinlin
Copy link
Contributor

Modify the color of the menuitem hover to be the same as AlphabetCategoryPopup

Issue: linuxdeepin/developer-center#8807

@xionglinlin
Copy link
Contributor Author

/review @BLumia

@github-actions github-actions bot requested a review from BLumia June 24, 2024 06:07
BLumia
BLumia previously approved these changes Jun 24, 2024
Modify the background of the menuitem to be the same as AlphabetCategoryPopup

Issue: linuxdeepin/developer-center#8807
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • background矩形中使用了DStyle.Style.menu.item.widthDStyle.Style.menu.item.height,建议使用更具体的属性或常量来代替,以提高代码的可读性和可维护性。
  • radius属性被设置为1,但没有注释说明原因。如果这是一个临时措施,应该添加一个TODO注释,以便未来的开发者了解这一更改的上下文。
  • color: ColorSelector.hoveredPalette使用了ColorSelectorhoveredPalette属性,但没有检查ColorSelector是否已经被正确初始化。
  • visible: menuItem.down || menuItem.highlighted表示背景的可见性取决于menuItemdownhighlighted状态。这种逻辑可能不是一成不变的,建议添加注释说明其逻辑。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jun 24, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 0a7d2b1 into linuxdeepin:master Jun 24, 2024
9 of 10 checks passed
@xionglinlin xionglinlin deleted the fix/menuitem branch June 27, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants