Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to 0.7.4 #332

Merged
merged 4 commits into from
Jun 26, 2024
Merged

bump version to 0.7.4 #332

merged 4 commits into from
Jun 26, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Jun 24, 2024 •
edited
Loading

@kegechen kegechen changed the title Release/rc2 Release/rc2 0.7.4 Jun 24, 2024
@kegechen kegechen changed the title Release/rc2 0.7.4 bump version to 0.7.4 Jun 24, 2024
@github-actions GitHub Actions
Copy link

TAG Bot

TAG: 0.7.4
EXISTED: no
DISTRIBUTION: unstable

@kegechen
Copy link
Contributor Author

/integrate

@kegechen kegechen requested review from BLumia and robertkill and removed request for BLumia June 24, 2024 06:00
@deepin-community-ci-bot deepin-community-ci-bot bot mentioned this pull request Jun 24, 2024
Open
@github-actions GitHub Actions
Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1643
PrNumber: 1643
PrBranch: auto-integration-9640334033

@kegechen
Copy link
Contributor Author

/integrate

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在launchercontroller.h和launchercontroller.cpp中新增的isFullScreenFrame方法可能需要更详细的注释说明其用途和行为。
  • 在FolderGridViewPopup.qml中的onWheel函数中，对wheel.angleDelta.x和wheel.angleDelta.y的除以8的操作可能需要更多的测试和验证，以确保在不同设备和操作系统上的表现一致。
  • 在FullscreenFrame.qml中，Connections组件的onDropped函数被移到了Control组件内部，这可能会影响原有的功能，需要确认这是否是预期的行为。
  • 在appearance.cpp中，connect方法的修改增加了对LauncherController当前帧为"FullscreenFrame"`的检查，这可能是为了确保在不同的桌面环境下的兼容性。但是，这种硬编码的检查可能不够灵活，应该考虑使用更通用的方法来处理这种情况。

是否建议立即修改:
是

  • 添加必要的注释有助于其他开发者理解代码的意图和功能，这是一个较小的改动但对代码可维护性有重要影响。
  • 确保onWheel函数中的wheel.angleDelta.x和wheel.angleDelta.y的除以8的操作是正确的，并且不会引入潜在的错误。
  • 验证Connections组件的移动是否符合预期的功能，并确保这一改动不会破坏现有的代码逻辑。
  • 考虑使用更灵活的方法来处理LauncherController的帧变化，而不是硬编码的检查，以提高代码的灵活性和可维护性。

@kegechen kegechen requested a review from BLumia June 25, 2024 09:26
@kegechen
Copy link
Contributor Author

/review @BLumia 测试过了

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 2f7527f into linuxdeepin:release/rc2 Jun 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

@robertkill robertkill Awaiting requested review from robertkill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kegechen @deepin-ci-robot @BLumia @zsien