Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: udpate blur background on window mode changed #329

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

kegechen
Copy link
Contributor

window frame to fullscreen frame update current background

Issue: linuxdeepin/developer-center#8828

window frame to fullscreen frame update current background

Issue: linuxdeepin/developer-center#8828
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • LauncherController::isFullScreenFrame函数中,直接使用硬编码的字符串"FullscreenFrame"可能会导致维护问题,建议使用常量或枚举来代替。
  • Appearance::updateCurrentWallpaperBlurhash函数中,对LauncherController::instance().visible()LauncherController::instance().isFullScreenFrame()的检查可能会导致不必要的性能开销,建议在connect事件连接时进行更详细的检查。
  • Appearance::updateCurrentWallpaperBlurhash函数中的两个connect调用可能会导致同一个槽函数被多次调用,这可能不是预期的行为,建议检查是否有必要进行这种连接。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 789cd4c into linuxdeepin:master Jun 20, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants