Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clear search text when switching mode #314

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 12, 2024

@zsien zsien requested review from BLumia and 18202781743 June 12, 2024 07:56
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在FullscreenFrame.qml中,当点击退出全屏的图标时,应该直接设置LauncherController.currentFrame,而不是设置searchEdit.text为空字符串。
  • 在BottomBar.qml中,当点击全屏按钮时,searchEdit.text被设置为空字符串,但这是在点击事件中不推荐的做法。应该在点击前先保存当前的文本内容,然后在点击后恢复。

是否建议立即修改:

@zsien zsien changed the title chore: clear search text after switching mode chore: clear search text when switching mode Jun 12, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien merged commit 3d115c8 into linuxdeepin:master Jun 13, 2024
9 of 10 checks passed
@zsien zsien deleted the zs/fix/switchmodesearch branch June 13, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants