New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: folder did not remove without item #309

Merged

deepin-bot merged 1 commit into linuxdeepin:master from kegechen:release/rc2

Jun 7, 2024

Contributor

kegechen commented Jun 7, 2024 •

edited

Loading

itemount instead of pagecount

Issue: linuxdeepin/developer-center#8947


          fix: folder did not remove without item

d3e0270

itemount instead of pagecount

deepin-ci-robot commented Jun 7, 2024

deepin pr auto review

关键摘要:

代码中的变量名 srcFolder 更改为 srcFolderId 可能会影响其他未显示的代码部分，需要确认这一更改是否已在所有相关代码中实施。
检查 srcFolder->pageCount() 是否正确计算了页面数量，因为通常 pageCount() 方法返回的是分页的数量，而不是总项目数。
确认 dstFolder 是否总是与 srcFolder 不同，如果是，则更改条件判断逻辑可能会影响预期行为。

是否建议立即修改:

是，需要确保变量名更改不会影响其他代码部分，并且新的条件判断逻辑与预期行为一致。

zsien approved these changes

View reviewed changes

deepin-ci-robot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor Author

kegechen commented Jun 7, 2024

/forcemerge

deepin-bot bot commented Jun 7, 2024

This pr force merged! (status: blocked)

deepin-bot bot merged commit 4498c77 into linuxdeepin:master

7 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet