Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when compositing turned off a rounded corner border appears inside the window #304

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 5, 2024

@zsien zsien requested review from 18202781743 and a team June 5, 2024 07:53
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在QtObject中添加了对WindowManagerHelper的依赖,需要确认是否所有使用该对象的代码都已更新以处理新的条件逻辑。
  • 修改了InsideBoxBorder的radius属性,使用了WindowManagerHelper来判断是否启用圆角,这是一个好的做法,但需要确保相关文档和测试用例都已更新以反映这一变化。

是否建议立即修改:

  • 是,建议立即更新相关文档和测试用例,以确保代码的完整性和正确性。同时,需要检查是否有其他代码依赖于WindowManagerHelper,并确保它们也得到了相应的更新和测试。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
Copy link
Contributor

kegechen commented Jun 5, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jun 5, 2024

This pr cannot be merged! (status: blocked)

@zsien zsien merged commit 8d13c8d into linuxdeepin:master Jun 5, 2024
9 of 10 checks passed
@zsien zsien deleted the zs/fix/noeffects branch June 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants