Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: " fix: more than one hover status for Menu" #303

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented Jun 3, 2024

this commit revert 9a4c4e2

Issue: linuxdeepin/developer-center#8862

或许 linuxdeepin/developer-center#8571 需要重新测试一下? @BLumia @18202781743

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Menu的属性中添加了modal: true,确保这是预期的行为,因为这可能会影响用户交互。

是否建议立即修改:

  • 否,这个改动看起来是对QML代码的简单修复,没有引入新的问题。但是,建议确认这个改动是否符合预期的用户体验。如果这个属性是必要的,并且已经通过了适当的测试,那么这个改动可以保留。如果这个属性是无意的或者不必要的,那么应该撤销这个改动。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit fe1fd85 into master Jun 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants