Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folder popup selectionColor not highlight #301

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen requested a review from 18202781743 May 30, 2024 06:44
@kegechen
Copy link
Contributor Author

kegechen commented May 30, 2024

@18202781743 还没改完, 按说这里设置高亮色应该就可以了,但是在 Popup 中的 TextInput 貌似设置 selectionColor 无效,写什么颜色都无效。 background 模糊效果有影响

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

虽然设置了选中高亮色,但是 dtk 的 PopUp 模糊效果
会导致颜色失效( background:null 验证 ),待 dtk 修复即可。

Issue: linuxdeepin/developer-center#8802
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在代码中添加了TODO注释,指出了需要解决的问题。
  • 更改了selectionColor的值,从硬编码的值更改为使用palette.highlight

是否建议立即修改:

  • 是,建议立即修改TODO注释,确保问题得到解决。
  • 是,如果palette.highlight的值依赖于当前的QML上下文,那么这个更改可能会导致问题。需要确保新的颜色值是正确的,并且与当前的UI设计兼容。

@kegechen
Copy link
Contributor Author

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jun 13, 2024

This pr cannot be merged! (status: blocked)

@kegechen kegechen merged commit c6308f4 into linuxdeepin:master Jun 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants