Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: folder icon radius too small #299

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: folder icon radius too small #299

merged 1 commit into from
May 30, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen
Copy link
Contributor Author

kegechen commented May 30, 2024 •
edited
Loading

3840*2160 1.5 倍缩放

企业微信截图_17170343778188
无缩放
image

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中，qGuiApp->devicePixelRatio() 可能需要考虑跨平台兼容性和用户设置的设备像素比。
  • 使用 qreal 类型来计算 radius 可能会导致精度问题，特别是在高分辨率屏幕上。
  • 注释 // uri: image://provider/icon-name:icon-name:icon-name 应该解释清楚该 URI 的格式和用途。

是否建议立即修改:

  • 是

@kegechen
Copy link
Contributor Author

@BLumia 貌似目录里面的图标大小也期望跟着缩放放大

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit eb655c3 into linuxdeepin:master May 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

@18202781743 18202781743 Awaiting requested review from 18202781743

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kegechen @deepin-ci-robot @BLumia