Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppListview can not launchApp onKeypressed #292

Merged
merged 1 commit into from
May 29, 2024

Conversation

kegechen
Copy link
Contributor

@kegechen kegechen commented May 28, 2024

作用域小了,往外移一个级别即可

Issue: linuxdeepin/developer-center#8584

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 移除了对 Keys.onReturnPressedKeys.onSpacePressed 的处理逻辑,可能会影响用户体验,特别是对于那些依赖于这些快捷键启动应用程序的用户。
  • 代码中没有看到对 launchApp 函数的定义和其行为的修改,这可能意味着快捷键的更改没有实际的效果。

是否建议立即修改:

  • 是,需要确认快捷键更改的意图,并确保不会对现有用户产生负面影响。如果更改是故意的,应该提供相应的更新说明或迁移策略。如果这是一个错误,应该恢复快捷键处理逻辑。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 034f6ca into linuxdeepin:master May 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants